Skip to content

Add custom signal limits link and fix Javadoc List Formatting #6722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlazo merged 4 commits into from
Feb 26, 2025
Merged

Add custom signal limits link and fix Javadoc List Formatting #6722

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e8790b
Add custom signal limits link and fix Javadoc List Formatting
tusharkhandelwal8 Feb 25, 2025
6d87ea6
Merge branch 'main' into updateFormatting
tusharkhandelwal8 Feb 25, 2025
eb44b5c
Remove TODO to add documentation link.
tusharkhandelwal8 Feb 25, 2025
3f0ddc2
Update statement for custom signal limits.
tusharkhandelwal8 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,16 +656,17 @@ private Task<Void> setDefaultsWithStringsMapAsync(Map<String, String> defaultsSt
* Asynchronously changes the custom signals for this {@link FirebaseRemoteConfig} instance.
*
* <p>Custom signals are subject to limits on the size of key/value pairs and the total
* number of signals. Any calls that exceed these limits will be discarded.
* number of signals. Any calls that exceed these limits will be discarded. See <a
* href="https://firebase.google.com/docs/remote-config/parameters?template_type=client#custom-signal-limits">Custom
* Signal Limits</a>.
*
* @param customSignals The custom signals to set for this instance.
* <ol>
* <ul>
* <li>New keys will add new key-value pairs in the custom signals.
* <li>Existing keys with new values will update the corresponding signals.
* <li>Setting a key's value to {@code null} will remove the associated signal.
* </ol>
* </ul>
*/
// TODO(b/385028620): Add link to documentation about custom signal limits.
@NonNull
public Task<Void> setCustomSignals(@NonNull CustomSignals customSignals) {
return Tasks.call(
Expand Down
Loading