Use Dagger for dependency injection in Sessions #6745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected Products
Test Logs |
Test Results 38 files 38 suites 56s ⏱️ Results for commit 86febc4. ♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
mrober
force-pushed
the
mrober/aqs-dagger
branch
from
0c2c9b8 to
86febc4
Compare
tejasd
approved these changes
Mar 10, 2025
themiswang
approved these changes
Mar 10, 2025
rlazo
pushed a commit
that referenced
this pull request
Mar 11, 2025
tejasd
pushed a commit
that referenced
this pull request
Apr 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Dagger for dependency injection in Sessions.
This follows Firebase best practices, see https://firebase.github.io/firebase-android-sdk/best_practices/dependency_injection. Also, reducing the number of Firebase Components improves initializing time.
This is mostly just the scaffolding. Some of the classes and interfaces are still a little awkward, they can be cleaned up later. The
@Backgroundand@Blockingexecutors are now enforced by Dagger, making them less error prone. The unit tests still need to be updated, right now they still rely on the old Firebase Components model to inject fake dependencies, I just added a Dagger component to bridge them instead of refactoring, that can be done later too.Singletons are now enforced by Dagger, also making the code less error prone.