Skip to content

Store registered context for sync task unregistrations #6747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Store registered context for sync task unregistrations #6747

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94b07f9
Store registered context for sync task unregistrations
Mar 7, 2025
0b970a4
fix formatting
Mar 7, 2025
8f8d9c3
fix formatting
Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions firebase-messaging/src/main/java/com/google/firebase/messaging/SyncTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ boolean isDeviceConnected() {
static class ConnectivityChangeReceiver extends BroadcastReceiver {

@Nullable private SyncTask task; // task is set to null after it has been fired.
@Nullable private Context context;

public ConnectivityChangeReceiver(SyncTask task) {
this.task = task;
Expand All @@ -171,7 +172,10 @@ public void registerReceiver() {
Log.d(TAG, "Connectivity change received registered");
}
IntentFilter intentFilter = new IntentFilter(ConnectivityManager.CONNECTIVITY_ACTION);
task.getContext().registerReceiver(this, intentFilter);
if (task != null) {
context = task.getContext();
context.registerReceiver(this, intentFilter);
}
}

@Override
Expand All @@ -191,8 +195,10 @@ public void onReceive(Context context, Intent intent) {
Log.d(TAG, "Connectivity changed. Starting background sync.");
}
task.firebaseMessaging.enqueueTaskWithDelaySeconds(task, 0);
task.getContext().unregisterReceiver(this);
task = null;
if (this.context != null) {
this.context.unregisterReceiver(this);
task = null;
}
}
}

Expand Down
Loading