Skip to content

[Functions] Send the placeholder appcheck token in case of error #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 10, 2025
Merged

[Functions] Send the placeholder appcheck token in case of error #6750

merged 8 commits into from
Mar 10, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 10, 2025

tracking b/399116207

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 10, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-functions

    Overall coverage changed from ? (7c03f49) to 24.90% (e632c9d) by ?.

    22 individual files with coverage change

    FilenameBase (7c03f49)Merge (e632c9d)Diff
    ContextProvider.kt?0.00%?
    DaggerFunctionsComponent.java?100.00%?
    FirebaseContextProvider.kt?27.78%?
    FirebaseContextProvider_Factory.java?0.00%?
    FirebaseFunctions.kt?24.52%?
    FirebaseFunctionsException.kt?0.00%?
    FirebaseFunctions_Factory.java?0.00%?
    Functions.kt?100.00%?
    FunctionsComponent.kt?100.00%?
    FunctionsComponent_MainModule_Companion_BindProjectIdFactory.java?0.00%?
    FunctionsMultiResourceComponent.kt?100.00%?
    FunctionsMultiResourceComponent_Factory.java?0.00%?
    FunctionsMultiResourceComponent_FirebaseFunctionsFactory_Impl.java?0.00%?
    FunctionsRegistrar.kt?100.00%?
    HttpsCallableContext.kt?0.00%?
    HttpsCallableOptions.kt?55.56%?
    HttpsCallableReference.kt?44.83%?
    HttpsCallableResult.kt?0.00%?
    HttpsCallOptions.kt?52.63%?
    PublisherStream.kt?0.00%?
    Serializer.kt?5.26%?
    StreamResponse.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/m0vviORFAR.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

Test Results

14 files  ±0  14 suites  ±0   12s ⏱️ ±0s
23 tests ±0  23 ✅ ±0  0 💤 ±0  0 ❌ ±0 
46 runs  ±0  46 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a941092. ± Comparison against base commit 7c03f49.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 10, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (7c03f49)Merge (e632c9d)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-functions

    TypeBase (7c03f49)Merge (e632c9d)Diff
    aar?80.4 kB? (?)
    apk (aggressive)?439 kB? (?)
    apk (release)?5.46 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/u8CUGLBPJh.html

@rlazo rlazo requested review from daymxn and emilypgoogle March 10, 2025 19:06
rlazo and others added 2 commits March 10, 2025 15:06
daymxn
daymxn approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, but LGTM

@rlazo rlazo merged commit dfd0d7c into main Mar 10, 2025
28 of 30 checks passed
@rlazo rlazo deleted the rl.functions.appcheck.placeholder branch March 10, 2025 21:32
rlazo added a commit that referenced this pull request Mar 11, 2025
@rlazo @daymxn
[Functions] Send the placeholder appcheck token in case of error (#6750)
facccae 
tracking b/399116207

---------

Co-authored-by: Daymon <[email protected]>
tejasd pushed a commit that referenced this pull request Apr 1, 2025
@rlazo @daymxn @tejasd
[Functions] Send the placeholder appcheck token in case of error (#6750)
c0fba25 
tracking b/399116207

---------

Co-authored-by: Daymon <[email protected]>
@firebase firebase locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

1 more reviewer

@daymxn daymxn daymxn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlazo @google-oss-bot @daymxn