Skip to content

Conversation

emilypgoogle
Copy link
Collaborator

We need explicit permissions to create PRs now, this adjusts our create release workflow to specify them.

@emilypgoogle emilypgoogle requested review from daymxn and rlazo March 12, 2025 18:24
Copy link
Contributor

github-actions bot commented Mar 12, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Mar 12, 2025

Test Results

 1 051 files  + 32   1 051 suites  +32   34m 37s ⏱️ +39s
 5 896 tests ±  0   5 873 ✅ ±  0  22 💤 ±0  1 ❌ ±0 
12 008 runs  +341  11 963 ✅ +341  44 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit db0b882. ± Comparison against base commit bcdb963.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (bcdb963) to 50.14% (3a29456) by -0.03%.

    FilenameBase (bcdb963)Merge (3a29456)Diff
    DefaultPersistenceManager.java75.73%74.76%-0.97%
    DoubleNode.java100.00%88.24%-11.76%
  • firebase-firestore

    Overall coverage changed from 45.77% (bcdb963) to 45.77% (3a29456) by -0.00%.

    FilenameBase (bcdb963)Merge (3a29456)Diff
    PatchMutation.java100.00%98.39%-1.61%
  • firebase-ml-modeldownloader

    Overall coverage changed from 82.04% (bcdb963) to 82.11% (3a29456) by +0.06%.

    FilenameBase (bcdb963)Merge (3a29456)Diff
    FirebaseModelDownloader.java84.05%84.66%+0.61%
  • firebase-sessions

    Overall coverage changed from 71.25% (bcdb963) to 71.35% (3a29456) by +0.10%.

    FilenameBase (bcdb963)Merge (3a29456)Diff
    RemoteSettings.kt86.96%88.41%+1.45%
  • firebase-storage

    Overall coverage changed from 84.33% (bcdb963) to 83.96% (3a29456) by -0.37%.

    FilenameBase (bcdb963)Merge (3a29456)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.99%83.38%-0.60%
    UploadTask.java83.17%81.52%-1.65%
  • firebase-messaging

    FilenameBase (bcdb963)Merge (3a29456)Diff
    FirebaseMessaging.java76.80%75.60%-1.20%
    Metadata.java36.51%41.27%+4.76%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mMwdGEP6gA.html

@emilypgoogle emilypgoogle merged commit 17c302e into main Mar 12, 2025
264 of 267 checks passed
@emilypgoogle emilypgoogle deleted the ep/workflow-permissions branch March 12, 2025 20:18
tejasd pushed a commit that referenced this pull request Apr 1, 2025
We need explicit permissions to create PRs now, this adjusts our create
release workflow to specify them.
@firebase firebase locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants