Skip to content

build(deps): bump glide from 4.11.0 to 4.16.0 #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

build(deps): bump glide from 4.11.0 to 4.16.0 #6767

merged 2 commits into from
Apr 16, 2025

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2025 •
edited
Loading

Bumps glide from 4.11.0 to 4.16.0.
Updates com.github.bumptech.glide:compiler from 4.11.0 to 4.16.0

Release notes

Sourced from com.github.bumptech.glide:compiler's releases.

Glide 4.16.0

This release focuses on some build improvements and Compose. The two major Compose improvements are adding support for Compose specific transitions (e.g. cross fade) and supporting recomposition based on request state using GlideSubcomposition. There's also been a bunch of internal refactoring to move away from Painters to Modifier nodes based on feedback from the Compose team. This is still an alpha release of Compose, but barring unexpectedly negative feedback, the next release should be beta.

This should be the last release of Glide that targets Java 7. That probably means our next release will be a major version change.

Features

Compose

Bugs

Deprecations

  • placeholderOf(@Composable) in GlideImage is deprecated, use GlideSubcomposition instead. Keep in mind that using either forces a recomposition each time the state of the image load changes. Recomposition will have a significant performance penalty in scrolling lists and should be avoided.

Behavior Changes

Breaking Changes

  • [Late edit, sorry!]: Added @Nullable and @NonNull annotations to RequestListener via 60b567e5feec70ba810a663e56a10d837f26c56c. This will break Kotlin implementations that make different assumptions about nullability.

Build Changes

... (truncated)

Commits
  • 374306f Bump version to 4.16.0 / alpha5
  • 5d2fb67 Clean up some duplicate size logic in GlideModifier.
  • b329401 Influence layout using intrinsics in GlideNode
  • d10c5ff Add a Transition API and a CrossFade Transition for Compose
  • cb2b1dc Replace flows in GlideSubcomposition with a listener on GlideNode
  • 60b567e Remove GlidePainter in favor of Modifier nodes / Flows
  • 8f6d645 Add a isEquivalentTo method to correctly check equality
  • 0b62103 Remove empty AndroidManifest.xml files.
  • 401d7e5 Migrate <manifest package="..." in AndroidManifest.xml to namespace '...' in ...
  • 49ddc01 Ensure one new line at end of modified files.
  • Additional commits viewable in compare view

Updates com.github.bumptech.glide:glide from 4.11.0 to 4.16.0

Release notes

Sourced from com.github.bumptech.glide:glide's releases.

Glide 4.16.0

This release focuses on some build improvements and Compose. The two major Compose improvements are adding support for Compose specific transitions (e.g. cross fade) and supporting recomposition based on request state using GlideSubcomposition. There's also been a bunch of internal refactoring to move away from Painters to Modifier nodes based on feedback from the Compose team. This is still an alpha release of Compose, but barring unexpectedly negative feedback, the next release should be beta.

This should be the last release of Glide that targets Java 7. That probably means our next release will be a major version change.

Features

Compose

Bugs

Deprecations

  • placeholderOf(@Composable) in GlideImage is deprecated, use GlideSubcomposition instead. Keep in mind that using either forces a recomposition each time the state of the image load changes. Recomposition will have a significant performance penalty in scrolling lists and should be avoided.

Behavior Changes

Breaking Changes

  • [Late edit, sorry!]: Added @Nullable and @NonNull annotations to RequestListener via 60b567e5feec70ba810a663e56a10d837f26c56c. This will break Kotlin implementations that make different assumptions about nullability.

Build Changes

... (truncated)

Commits
  • 374306f Bump version to 4.16.0 / alpha5
  • 5d2fb67 Clean up some duplicate size logic in GlideModifier.
  • b329401 Influence layout using intrinsics in GlideNode
  • d10c5ff Add a Transition API and a CrossFade Transition for Compose
  • cb2b1dc Replace flows in GlideSubcomposition with a listener on GlideNode
  • 60b567e Remove GlidePainter in favor of Modifier nodes / Flows
  • 8f6d645 Add a isEquivalentTo method to correctly check equality
  • 0b62103 Remove empty AndroidManifest.xml files.
  • 401d7e5 Migrate <manifest package="..." in AndroidManifest.xml to namespace '...' in ...
  • 49ddc01 Ensure one new line at end of modified files.
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025 •
edited
Loading

Test Results

 1 053 files  + 1 053   1 053 suites  +1 053   35m 1s ⏱️ + 35m 1s
 5 874 tests + 5 874   5 851 ✅ + 5 851  22 💤 +22  1 ❌ +1 
12 135 runs  +12 135  12 090 ✅ +12 090  44 💤 +44  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 35e7e74. ± Comparison against base commit 5aff679.

♻️ This comment has been updated with latest results.

@rlazo
Copy link
Collaborator

rlazo commented Apr 15, 2025

@dependabot rebase

@dependabot
build(deps): bump glide from 4.11.0 to 4.16.0
8597888 
Bumps `glide` from 4.11.0 to 4.16.0.

Updates `com.github.bumptech.glide:compiler` from 4.11.0 to 4.16.0
- [Release notes](https://github.com/bumptech/glide/releases)
- [Commits](bumptech/glide@v4.11.0...v4.16.0)

Updates `com.github.bumptech.glide:glide` from 4.11.0 to 4.16.0
- [Release notes](https://github.com/bumptech/glide/releases)
- [Commits](bumptech/glide@v4.11.0...v4.16.0)

---
updated-dependencies:
- dependency-name: com.github.bumptech.glide:compiler
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.github.bumptech.glide:glide
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/glide-4.16.0 branch from 66fca6d to 8597888 Compare April 15, 2025 14:30
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@rlazo rlazo closed this Apr 15, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 15, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@rlazo rlazo reopened this Apr 15, 2025
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Size Report 1

Affected Products

  • firebase-inappmessaging-display

    TypeBase (5aff679)Merge (d5412ee)Diff
    apk (aggressive)2.24 MB2.24 MB+3.04 kB (+0.1%)
    apk (release)15.9 MB15.9 MB+79.2 kB (+0.5%)

  • firebase-inappmessaging-display-ktx

    TypeBase (5aff679)Merge (d5412ee)Diff
    apk (aggressive)2.24 MB2.25 MB+3.17 kB (+0.1%)
    apk (release)15.9 MB15.9 MB+79.2 kB (+0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bpEsEKNNgF.html

@rlazo
Copy link
Collaborator

rlazo commented Apr 15, 2025

Waiting for #6875

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.14% (5aff679) to 50.16% (d5412ee) by +0.02%.

    FilenameBase (5aff679)Merge (d5412ee)Diff
    DoubleNode.java88.24%100.00%+11.76%

  • firebase-firestore

    Overall coverage changed from 45.78% (5aff679) to 45.78% (d5412ee) by -0.00%.

    FilenameBase (5aff679)Merge (d5412ee)Diff
    PatchMutation.java100.00%98.39%-1.61%

  • firebase-storage

    Overall coverage changed from 84.33% (5aff679) to 83.92% (d5412ee) by -0.42%.

    FilenameBase (5aff679)Merge (d5412ee)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.99%83.38%-0.60%
    StreamDownloadTask.java88.89%88.41%-0.48%
    UploadTask.java83.17%81.52%-1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/W8VH1jrHq3.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (d5412ee) and the base commit (5aff679) are not available.

No macrobenchmark data found for the base commit (5aff679). Analysis for the CI merge commit (d5412ee) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gjsNh91TpO/index.html

@rlazo rlazo merged commit e98dd2c into main Apr 16, 2025
418 of 424 checks passed
@rlazo rlazo deleted the dependabot/gradle/glide-4.16.0 branch April 16, 2025 14:57
@firebase firebase locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rlazo @google-oss-bot