Skip to content

Update CHANGELOG.md for firebase-appdistribution-api #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Update CHANGELOG.md for firebase-appdistribution-api #6782

wants to merge 4 commits into from

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 19, 2025 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (51b4a1c) and merge commit (b36463a).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZavDqB6p3U.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

Test Results

 2 files   -    64   2 suites   - 64   14s ⏱️ - 1m 2s
 6 tests  -   546   6 ✅  -   545  0 💤  - 1  0 ❌ ±0 
12 runs   - 1 092  12 ✅  - 1 090  0 💤  - 2  0 ❌ ±0 

Results for commit 3d65904. ± Comparison against base commit 51b4a1c.

This pull request removes 552 and adds 6 tests. Note that renamed tests count towards both. 
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (normal cases)
…

com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ checkForNewRelease_failsWithNotImplemented
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ isTesterSignedIn_returnsFalse
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ signInTester_failsWithNotImplemented
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ signOutTester_doesNotThrow
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ updateApp
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ updateIfNewReleaseAvailable

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 19, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (51b4a1c) and merge commit (b36463a).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dYgqtBConW.html

@rlazo
Copy link
Collaborator

rlazo commented Apr 15, 2025

what's the status of this PR?

@lfkellogg
Copy link
Contributor Author

what's the status of this PR?

Looks like this library (firebase-appdistribution-api) was correctly released along with firebase-appdistribution in the last release: https://firebase.google.com/support/release-notes/android#app-distro-api_v16-0-0-beta15

Both are at 16.0.0-beta15.

I've updated this PR to better align with reality. Does this look right or is there a different process to follow here?

@lfkellogg lfkellogg requested a review from rlazo April 16, 2025 21:12
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-appdistribution

    DeviceStatisticsDistributions
    oriole-32
    Percentile51b4a1cb36463aDiffSignificant (?)
    p10594 ±482 μs1.26 ±0.7 ms+666 μs (+112.0%)NO
    p25624 ±513 μs1.32 ±0.7 ms+696 μs (+111.4%)NO
    p50698 ±542 μs1.43 ±0.7 ms+733 μs (+105.0%)NO
    p75838 ±547 μs1.60 ±0.8 ms+759 μs (+90.5%)NO
    p901.03 ±0.6 ms1.94 ±1 ms+911 μs (+88.2%)NO

    20 test runs in comparison
    CommitTest Runs
    51b4a1c
    • 2025-04-16_19:58:17.110055_roZg
    • 2025-04-16_19:58:17.110092_lFvN
    • 2025-04-16_19:58:17.110103_agxz
    • 2025-04-16_19:58:17.110112_OSvX
    • 2025-04-16_19:58:17.110118_jVyB
    • 2025-04-16_19:58:17.110125_HNaK
    • 2025-04-16_19:58:17.110132_UYnC
    • 2025-04-16_19:58:17.110139_UNuP
    • 2025-04-16_19:58:17.110145_hYUz
    • 2025-04-16_19:58:17.110152_GQkO
    b36463a
    • 2025-04-16_21:30:15.545774_byih
    • 2025-04-16_21:30:15.545829_XBPy
    • 2025-04-16_21:30:15.545841_rmki
    • 2025-04-16_21:30:15.545849_xwJi
    • 2025-04-16_21:30:15.545856_wmjJ
    • 2025-04-16_21:30:15.545863_pHNQ
    • 2025-04-16_21:30:15.545876_rkNO
    • 2025-04-16_21:30:15.545882_RLzs
    • 2025-04-16_21:30:15.545889_ahQi
    • 2025-04-16_21:30:15.545895_UCHF
    redfin-30
    Percentile51b4a1cb36463aDiffSignificant (?)
    p102.45 ±2 ms1.60 ±2 ms-849 μs (-34.6%)NO
    p252.55 ±2 ms1.67 ±2 ms-878 μs (-34.4%)NO
    p502.71 ±2 ms1.77 ±2 ms-932 μs (-34.4%)NO
    p752.91 ±2 ms1.92 ±2 ms-998 μs (-34.2%)NO
    p903.23 ±3 ms2.23 ±2 ms-995 μs (-30.8%)NO

    20 test runs in comparison
    CommitTest Runs
    51b4a1c
    • 2025-04-16_19:58:17.110055_roZg
    • 2025-04-16_19:58:17.110092_lFvN
    • 2025-04-16_19:58:17.110103_agxz
    • 2025-04-16_19:58:17.110112_OSvX
    • 2025-04-16_19:58:17.110118_jVyB
    • 2025-04-16_19:58:17.110125_HNaK
    • 2025-04-16_19:58:17.110132_UYnC
    • 2025-04-16_19:58:17.110139_UNuP
    • 2025-04-16_19:58:17.110145_hYUz
    • 2025-04-16_19:58:17.110152_GQkO
    b36463a
    • 2025-04-16_21:30:15.545774_byih
    • 2025-04-16_21:30:15.545829_XBPy
    • 2025-04-16_21:30:15.545841_rmki
    • 2025-04-16_21:30:15.545849_xwJi
    • 2025-04-16_21:30:15.545856_wmjJ
    • 2025-04-16_21:30:15.545863_pHNQ
    • 2025-04-16_21:30:15.545876_rkNO
    • 2025-04-16_21:30:15.545882_RLzs
    • 2025-04-16_21:30:15.545889_ahQi
    • 2025-04-16_21:30:15.545895_UCHF

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile51b4a1cb36463aDiffSignificant (?)
    p10198 ±5 ms198 ±3 ms+877 μs (+0.4%)NO
    p25204 ±4 ms204 ±3 ms+295 μs (+0.1%)NO
    p50211 ±5 ms211 ±4 ms+276 μs (+0.1%)NO
    p75218 ±5 ms219 ±5 ms+575 μs (+0.3%)NO
    p90226 ±6 ms229 ±7 ms+2.49 ms (+1.1%)NO

    20 test runs in comparison
    CommitTest Runs
    51b4a1c
    • 2025-04-16_19:58:17.110055_roZg
    • 2025-04-16_19:58:17.110092_lFvN
    • 2025-04-16_19:58:17.110103_agxz
    • 2025-04-16_19:58:17.110112_OSvX
    • 2025-04-16_19:58:17.110118_jVyB
    • 2025-04-16_19:58:17.110125_HNaK
    • 2025-04-16_19:58:17.110132_UYnC
    • 2025-04-16_19:58:17.110139_UNuP
    • 2025-04-16_19:58:17.110145_hYUz
    • 2025-04-16_19:58:17.110152_GQkO
    b36463a
    • 2025-04-16_21:30:15.545774_byih
    • 2025-04-16_21:30:15.545829_XBPy
    • 2025-04-16_21:30:15.545841_rmki
    • 2025-04-16_21:30:15.545849_xwJi
    • 2025-04-16_21:30:15.545856_wmjJ
    • 2025-04-16_21:30:15.545863_pHNQ
    • 2025-04-16_21:30:15.545876_rkNO
    • 2025-04-16_21:30:15.545882_RLzs
    • 2025-04-16_21:30:15.545889_ahQi
    • 2025-04-16_21:30:15.545895_UCHF
    redfin-30
    Percentile51b4a1cb36463aDiffSignificant (?)
    p10227 ±5 ms250 ±4 ms+23.0 ms (+10.1%)MAYBE
    p25232 ±5 ms256 ±4 ms+24.0 ms (+10.4%)YES
    p50239 ±4 ms264 ±4 ms+25.4 ms (+10.7%)YES
    p75246 ±4 ms273 ±4 ms+26.7 ms (+10.8%)YES
    p90255 ±5 ms290 ±6 ms+35.0 ms (+13.7%)YES

    20 test runs in comparison
    CommitTest Runs
    51b4a1c
    • 2025-04-16_19:58:17.110055_roZg
    • 2025-04-16_19:58:17.110092_lFvN
    • 2025-04-16_19:58:17.110103_agxz
    • 2025-04-16_19:58:17.110112_OSvX
    • 2025-04-16_19:58:17.110118_jVyB
    • 2025-04-16_19:58:17.110125_HNaK
    • 2025-04-16_19:58:17.110132_UYnC
    • 2025-04-16_19:58:17.110139_UNuP
    • 2025-04-16_19:58:17.110145_hYUz
    • 2025-04-16_19:58:17.110152_GQkO
    b36463a
    • 2025-04-16_21:30:15.545774_byih
    • 2025-04-16_21:30:15.545829_XBPy
    • 2025-04-16_21:30:15.545841_rmki
    • 2025-04-16_21:30:15.545849_xwJi
    • 2025-04-16_21:30:15.545856_wmjJ
    • 2025-04-16_21:30:15.545863_pHNQ
    • 2025-04-16_21:30:15.545876_rkNO
    • 2025-04-16_21:30:15.545882_RLzs
    • 2025-04-16_21:30:15.545889_ahQi
    • 2025-04-16_21:30:15.545895_UCHF

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eWYo1A3OkY/index.html

@lfkellogg
Copy link
Contributor Author

what's the status of this PR?

Looks like this library (firebase-appdistribution-api) was correctly released along with firebase-appdistribution in the last release: https://firebase.google.com/support/release-notes/android#app-distro-api_v16-0-0-beta15

Both are at 16.0.0-beta15.

I've updated this PR to better align with reality. Does this look right or is there a different process to follow here?

Oh woops, just realized there's already an entry for 16.0.0-beta15 in this CHANGELOG after the last release. Closing this.

@lfkellogg lfkellogg closed this Apr 17, 2025
@lfkellogg lfkellogg deleted the lfkellogg-patch-1 branch April 17, 2025 14:23
@firebase firebase locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rlazo rlazo Awaiting requested review from rlazo

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lfkellogg @google-oss-bot @rlazo