Add basic Vertex Java compilation tests #6810
Conversation
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (5ff9d95) and merge commit (4e7af7d).Test Logs |
Size Report 1Affected ProductsNo changes between base commit (5ff9d95) and merge commit (4e7af7d).Test Logs |
There was a problem hiding this comment.
Great idea! And good job keeping them in the test source set:)
As a note, there are some builder patterns in Vertex that don't work as expected from Java and were omitted, as fixing that would be a breaking change.
Would you mind creating a bug to fix this, and adding a TODO(b/xxx): xxx comment at the builder site for these? And maybe adding what the ideal tests would be- but commented out with the TODO comment as well? Sounds like something we could fix at the next I/O or FireConf, and that would make it significantly easier to find and address when we're looking for things to change.
This is a starting point for compilation testing, broadly using most symbols Vertex exposes to Java users, lightly validating usability and structure. As a note, there are some builder patterns in Vertex that don't work as expected from Java and were omitted, as fixing that would be a breaking change.
3 participants
This is a starting point for compilation testing, broadly using most symbols Vertex exposes to Java users, lightly validating usability and structure. As a note, there are some builder patterns in Vertex that don't work as expected from Java and were omitted, as fixing that would be a breaking change.