Skip to content

Remove isRecording from constructor #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Remove isRecording from constructor #6817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
399c5c5
Remove `isRecording` from constructor
rlazo Mar 28, 2025
a1b1817
format fix
rlazo Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/LiveGenerativeModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,7 @@ internal constructor(
val receivedJson = webSession.incoming.receive().readBytes().toString(Charsets.UTF_8)
// TODO: Try to decode the json instead of string matching.
return if (receivedJson.contains("setupComplete")) {
LiveSession(
session = webSession,
backgroundDispatcher = backgroundDispatcher,
isRecording = false
)
LiveSession(session = webSession, backgroundDispatcher = backgroundDispatcher)
} else {
webSession.close()
throw GeminiConnectionHandshakeFailed()
Expand Down
2 changes: 1 addition & 1 deletion firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/LiveSession.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ public class LiveSession
internal constructor(
private val session: ClientWebSocketSession?,
@Background private val backgroundDispatcher: CoroutineContext,
private var isRecording: Boolean,
private var audioHelper: AudioHelper? = null
) {

private val audioQueue = ConcurrentLinkedQueue<ByteArray>()
private val playBackQueue = ConcurrentLinkedQueue<ByteArray>()
private var startedReceiving = false
private var receiveChannel: Channel<Frame> = Channel()
private var isRecording: Boolean = false

private companion object {
val TAG = LiveSession::class.java.simpleName
Expand Down
Loading