Skip to content

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Mar 28, 2025

Per b/407077784,

This bumps the compileSdkVersion and targetSdkVersion within our health metrics test app and benchmarks to match what our SDKs actually use. This also fixes the issue with our startup checks failing due to certain SDK dependencies requiring a higher compile target.

Copy link
Contributor

github-actions bot commented Mar 28, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@daymxn daymxn enabled auto-merge (squash) March 28, 2025 19:47
Copy link
Contributor

Test Results

 1 034 files  + 1 034   1 034 suites  +1 034   34m 45s ⏱️ + 34m 45s
 5 872 tests + 5 872   5 850 ✅ + 5 850  22 💤 +22  0 ❌ ±0 
11 807 runs  +11 807  11 763 ✅ +11 763  44 💤 +44  0 ❌ ±0 

Results for commit 3d4c523. ± Comparison against base commit cf2b7a8.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.14% (cf2b7a8) to 50.21% (e04fc35) by +0.07%.

    FilenameBase (cf2b7a8)Merge (e04fc35)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    DoubleNode.java88.24%100.00%+11.76%
  • firebase-firestore

    Overall coverage changed from 45.77% (cf2b7a8) to 45.77% (e04fc35) by -0.00%.

    FilenameBase (cf2b7a8)Merge (e04fc35)Diff
    SetMutation.java97.22%94.44%-2.78%
  • firebase-messaging

    Overall coverage changed from 84.21% (cf2b7a8) to 84.10% (e04fc35) by -0.11%.

    FilenameBase (cf2b7a8)Merge (e04fc35)Diff
    Metadata.java41.27%36.51%-4.76%
  • firebase-storage

    Overall coverage changed from 83.96% (cf2b7a8) to 84.33% (e04fc35) by +0.37%.

    FilenameBase (cf2b7a8)Merge (e04fc35)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    UploadTask.java81.52%83.17%+1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9qWnLAVnHW.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (e04fc35) and the base commit (cf2b7a8) are not available.

No macrobenchmark data found for the base commit (cf2b7a8). Analysis for the CI merge commit (e04fc35) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FbLhVq4dtB/index.html

@daymxn daymxn merged commit 9da772e into main Mar 28, 2025
262 of 266 checks passed
@daymxn daymxn deleted the daymon-update-health-metrics branch March 28, 2025 20:58
tejasd pushed a commit that referenced this pull request Apr 1, 2025
Per [b/407077784](https://b.corp.google.com/issues/407077784),

This bumps the `compileSdkVersion` and `targetSdkVersion` within our
health metrics test app and benchmarks to match what our SDKs actually
use. This also fixes the issue with our startup checks failing due to
certain SDK dependencies requiring a higher compile target.
@firebase firebase locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants