Skip to content

Update LiveModelFutures to return LiveSessionFutures instead of LiveSession #6834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025
Merged

Update LiveModelFutures to return LiveSessionFutures instead of LiveSession #6834

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
340b819
update
VinayGuthal Apr 3, 2025
5f1154b
update
VinayGuthal Apr 3, 2025
7ded9a8
update
VinayGuthal Apr 11, 2025
3faf0f7
remove unspecified modality
VinayGuthal Apr 15, 2025
bad6b83
update
VinayGuthal Apr 15, 2025
db5f3a0
update numbers
VinayGuthal Apr 15, 2025
6f5a249
update
VinayGuthal Apr 15, 2025
25c4774
update
VinayGuthal Apr 15, 2025
33b7a90
remove HEAD
VinayGuthal Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/java/LiveModelFutures.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ public abstract class LiveModelFutures internal constructor() {
* @throws [ServiceConnectionHandshakeFailedException] If the client was not able to establish a
* connection with the server.
*/
public abstract fun connect(): ListenableFuture<LiveSession>
public abstract fun connect(): ListenableFuture<LiveSessionFutures>

private class FuturesImpl(private val model: LiveGenerativeModel) : LiveModelFutures() {
override fun connect(): ListenableFuture<LiveSession> {
return SuspendToFutureAdapter.launchFuture { model.connect() }
override fun connect(): ListenableFuture<LiveSessionFutures> {
return SuspendToFutureAdapter.launchFuture { LiveSessionFutures.from(model.connect()) }
}
}

Expand Down
2 changes: 2 additions & 0 deletions firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/java/LiveSessionFutures.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,12 @@ public abstract class LiveSessionFutures internal constructor() {
* @param functionCallHandler A callback function to map function calls from the server to their
* response parts.
*/
@JvmOverloads
public abstract fun startAudioConversation(
functionCallHandler: ((FunctionCallPart) -> FunctionResponsePart)?
): ListenableFuture<Unit>


/**
* Stops the audio conversation with the Gemini Server.
*
Expand Down
4 changes: 2 additions & 2 deletions firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/LiveGenerationConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ private constructor(
public fun setFrequencyPenalty(frequencyPenalty: Float?): Builder = apply {
this.frequencyPenalty = frequencyPenalty
}
public fun setResponseModalities(responseModalities: ResponseModality?): Builder = apply {
this.responseModality = responseModalities
public fun setResponseModality(responseModality: ResponseModality?): Builder = apply {
this.responseModality = responseModality
}
public fun setSpeechConfig(speechConfig: SpeechConfig?): Builder = apply {
this.speechConfig = speechConfig
Expand Down
Loading