Add support for HarmBlockThreshold.OFF #6843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html 2025-04-07 17:02:42.342582816 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html 2025-04-07 17:00:31.465713991 +0000
@@ -69,6 +69,13 @@
<tr>
<td><code>static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></code></td>
<td>
+ <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#OFF()">OFF</a></code></div>
+ <p>All content is allowed regardless of harm.</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code>static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></code></td>
+ <td>
<div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#ONLY_HIGH()">ONLY_HIGH</a></code></div>
<p>Content with negligible to medium harm is allowed.</p>
</td>
@@ -99,6 +106,12 @@
<pre class="api-signature no-pretty-print">public static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#NONE()">NONE</a></pre>
<p>All content is allowed regardless of harm.</p>
</div>
+ <div class="api-item"><a name="getOFF()"></a><a name="setOFF()"></a><a name="getOFF--"></a><a name="setOFF--"></a>
+ <h3 class="api-name" id="OFF()">OFF</h3>
+ <pre class="api-signature no-pretty-print">public static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#OFF()">OFF</a></pre>
+ <p>All content is allowed regardless of harm.</p>
+ <p>The same as <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#NONE()">NONE</a></code>, but metadata when the corresponding <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> occurs will <b>NOT</b> be present in the response.</p>
+ </div>
<div class="api-item"><a name="getONLY_HIGH()"></a><a name="setONLY_HIGH()"></a><a name="getONLY_HIGH--"></a><a name="setONLY_HIGH--"></a>
<h3 class="api-name" id="ONLY_HIGH()">ONLY_HIGH</h3>
<pre class="api-signature no-pretty-print">public static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#ONLY_HIGH()">ONLY_HIGH</a></pre>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html 2025-04-07 17:02:42.333582756 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html 2025-04-07 17:00:31.455713925 +0000
@@ -49,6 +49,13 @@
<tr>
<td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></code></td>
<td>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#OFF()">OFF</a></code></div>
+ <p>All content is allowed regardless of harm.</p>
+ </td>
+ </tr>
+ <tr>
+ <td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></code></td>
+ <td>
<div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#ONLY_HIGH()">ONLY_HIGH</a></code></div>
<p>Content with negligible to medium harm is allowed.</p>
</td>
@@ -94,6 +101,12 @@
<pre class="api-signature no-pretty-print">val <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#NONE()">NONE</a>: <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></pre>
<p>All content is allowed regardless of harm.</p>
</div>
+ <div class="api-item"><a name="getOFF()"></a><a name="setOFF()"></a><a name="getOFF--"></a><a name="setOFF--"></a>
+ <h3 class="api-name" id="OFF()">OFF</h3>
+ <pre class="api-signature no-pretty-print">val <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#OFF()">OFF</a>: <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></pre>
+ <p>All content is allowed regardless of harm.</p>
+ <p>The same as <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#NONE()">NONE</a></code>, but metadata when the corresponding <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmCategory.html">HarmCategory</a></code> occurs will <b>NOT</b> be present in the response.</p>
+ </div>
<div class="api-item"><a name="getONLY_HIGH()"></a><a name="setONLY_HIGH()"></a><a name="getONLY_HIGH--"></a><a name="setONLY_HIGH--"></a>
<h3 class="api-name" id="ONLY_HIGH()">ONLY_HIGH</h3>
<pre class="api-signature no-pretty-print">val <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.Companion.html#ONLY_HIGH()">ONLY_HIGH</a>: <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/HarmBlockThreshold.html">HarmBlockThreshold</a></pre> |
Coverage Report 1Affected ProductsNo changes between base commit (9a07498) and merge commit (f5d90c0).Test Logs |
Test Results 18 files - 1 016 18 suites - 1 016 14s ⏱️ - 34m 22s Results for commit 5d5e2eb. ± Comparison against base commit 9a07498. This pull request removes 5786 tests.♻️ This comment has been updated with latest results. |
daymxn
commented
Apr 7, 2025
|
The public api surface has changed for the subproject firebase-vertexai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Should make it easier to find in the future
|
The public api surface has changed for the subproject firebase-vertexai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
1 similar comment
|
The public api surface has changed for the subproject firebase-vertexai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
rlazo
reviewed
Apr 7, 2025
Size Report 1Affected Products
Test Logs |
|
Don't forget to update the |
This reverts commit 2aa9a52.
rlazo
approved these changes
Apr 7, 2025
|
The public api surface has changed for the subproject firebase-vertexai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/409040155,
This adds support for
HarmBlockThreshold.OFF, and also adds javadocs that clearly articulate the difference it holds fromNONE.