[encoders] Replace deprecated Kotlin Stdlib functions with recommended ones #6845

rlazo · 2025-04-08T14:32:41Z

No description provided.

…d ones

github-actions · 2025-04-08T14:32:51Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2025-04-08T14:34:51Z

Coverage Report ¹

Affected Products

No changes between base commit (9a07498) and merge commit (c015807).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/DlA9JTUYLe.html

github-actions · 2025-04-08T14:44:35Z

Test Results

93 files - 941 93 suites - 941 6m 29s ⏱️ - 28m 7s
667 tests - 5 205 667 ✅ - 5 183 0 💤 - 22 0 ❌ ±0
1 315 runs - 10 492 1 315 ✅ - 10 448 0 💤 - 44 0 ❌ ±0

Results for commit a31c019. ± Comparison against base commit 9a07498.

This pull request removes 5205 tests.

com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

google-oss-bot · 2025-04-08T14:46:25Z

Size Report ¹

Affected Products

No changes between base commit (9a07498) and merge commit (c015807).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/SSfyefBojo.html

google-oss-bot · 2025-04-08T15:06:25Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (9a07498) and the CI merge commit (c015807)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 9a07498: https://storage.googleapis.com/firebase-sdk-metric-reports/9hgtzWlj6r/index.html
- c015807: https://storage.googleapis.com/firebase-sdk-metric-reports/MW8KWqHWdd/index.html

Startup Times

`fire-fcm`

Device Statistics Distributions

oriole-32

Percentile	`9a07498`	`c015807`	Diff	Significant (?)
p10	1.18 ±1 ms	1.06 ±0.6 ms	-116 μs (-9.9%)	NO
p25	1.28 ±1 ms	1.15 ±0.7 ms	-130 μs (-10.1%)	NO
p50	1.46 ±1 ms	1.29 ±0.7 ms	-171 μs (-11.7%)	NO
p75	1.62 ±1 ms	1.57 ±0.9 ms	-49.1 μs (-3.0%)	NO
p90	1.96 ±1 ms	1.93 ±1 ms	-30.6 μs (-1.6%)	NO

20 test runs in comparison

Commit	Test Runs
`9a07498`	2025-04-05_14:35:57.407055_PjRP 2025-04-05_14:35:57.407091_hoTA 2025-04-05_14:35:57.407113_EkkX 2025-04-05_14:35:57.407123_ltEF 2025-04-05_14:35:57.407129_TgOG 2025-04-05_14:35:57.407136_dcuv 2025-04-05_14:35:57.407143_bDkx 2025-04-05_14:35:57.407150_tyOb 2025-04-05_14:35:57.407156_OWOq 2025-04-05_14:35:57.407162_YJOg
`c015807`	2025-04-08_14:50:58.331810_hRns 2025-04-08_14:50:58.331848_Qbsb 2025-04-08_14:50:58.331858_ridB 2025-04-08_14:50:58.331865_phRu 2025-04-08_14:50:58.331871_mKMv 2025-04-08_14:50:58.331879_lYcV 2025-04-08_14:50:58.331886_urvK 2025-04-08_14:50:58.331893_DAcN 2025-04-08_14:50:58.331899_PVsO 2025-04-08_14:50:58.331906_pKFk

redfin-30

Percentile	`9a07498`	`c015807`	Diff	Significant (?)
p10	1.30 ±0.7 ms	2.26 ±2 ms	+964 μs (+74.2%)	NO
p25	1.45 ±0.9 ms	2.70 ±2 ms	+1.25 ms (+86.2%)	NO
p50	1.64 ±1 ms	3.32 ±3 ms	+1.68 ms (+102.3%)	NO
p75	1.97 ±1 ms	4.13 ±3 ms	+2.16 ms (+109.8%)	NO
p90	2.65 ±2 ms	5.44 ±4 ms	+2.79 ms (+105.4%)	NO

20 test runs in comparison

Commit	Test Runs
`9a07498`	2025-04-05_14:35:57.407055_PjRP 2025-04-05_14:35:57.407091_hoTA 2025-04-05_14:35:57.407113_EkkX 2025-04-05_14:35:57.407123_ltEF 2025-04-05_14:35:57.407129_TgOG 2025-04-05_14:35:57.407136_dcuv 2025-04-05_14:35:57.407143_bDkx 2025-04-05_14:35:57.407150_tyOb 2025-04-05_14:35:57.407156_OWOq 2025-04-05_14:35:57.407162_YJOg
`c015807`	2025-04-08_14:50:58.331810_hRns 2025-04-08_14:50:58.331848_Qbsb 2025-04-08_14:50:58.331858_ridB 2025-04-08_14:50:58.331865_phRu 2025-04-08_14:50:58.331871_mKMv 2025-04-08_14:50:58.331879_lYcV 2025-04-08_14:50:58.331886_urvK 2025-04-08_14:50:58.331893_DAcN 2025-04-08_14:50:58.331899_PVsO 2025-04-08_14:50:58.331906_pKFk

`fire-transport`

Device Statistics Distributions

oriole-32

Percentile	`9a07498`	`c015807`	Diff	Significant (?)
p10	28.2 ±14 μs	26.7 ±15 μs	-1.52 μs (-5.4%)	NO
p25	30.2 ±14 μs	28.4 ±16 μs	-1.84 μs (-6.1%)	NO
p50	33.0 ±15 μs	30.6 ±16 μs	-2.32 μs (-7.0%)	NO
p75	38.5 ±15 μs	34.3 ±16 μs	-4.21 μs (-10.9%)	NO
p90	46.5 ±14 μs	41.7 ±15 μs	-4.79 μs (-10.3%)	NO

20 test runs in comparison

Commit	Test Runs
`9a07498`	2025-04-05_14:35:57.407055_PjRP 2025-04-05_14:35:57.407091_hoTA 2025-04-05_14:35:57.407113_EkkX 2025-04-05_14:35:57.407123_ltEF 2025-04-05_14:35:57.407129_TgOG 2025-04-05_14:35:57.407136_dcuv 2025-04-05_14:35:57.407143_bDkx 2025-04-05_14:35:57.407150_tyOb 2025-04-05_14:35:57.407156_OWOq 2025-04-05_14:35:57.407162_YJOg
`c015807`	2025-04-08_14:50:58.331810_hRns 2025-04-08_14:50:58.331848_Qbsb 2025-04-08_14:50:58.331858_ridB 2025-04-08_14:50:58.331865_phRu 2025-04-08_14:50:58.331871_mKMv 2025-04-08_14:50:58.331879_lYcV 2025-04-08_14:50:58.331886_urvK 2025-04-08_14:50:58.331893_DAcN 2025-04-08_14:50:58.331899_PVsO 2025-04-08_14:50:58.331906_pKFk

redfin-30

Percentile	`9a07498`	`c015807`	Diff	Significant (?)
p10	50.8 ±25 μs	60.7 ±24 μs	+9.92 μs (+19.5%)	NO
p25	53.7 ±25 μs	63.5 ±25 μs	+9.84 μs (+18.3%)	NO
p50	58.2 ±26 μs	67.7 ±25 μs	+9.58 μs (+16.5%)	NO
p75	63.7 ±26 μs	73.1 ±25 μs	+9.42 μs (+14.8%)	NO
p90	74.6 ±26 μs	83.1 ±24 μs	+8.50 μs (+11.4%)	NO

20 test runs in comparison

Commit	Test Runs
`9a07498`	2025-04-05_14:35:57.407055_PjRP 2025-04-05_14:35:57.407091_hoTA 2025-04-05_14:35:57.407113_EkkX 2025-04-05_14:35:57.407123_ltEF 2025-04-05_14:35:57.407129_TgOG 2025-04-05_14:35:57.407136_dcuv 2025-04-05_14:35:57.407143_bDkx 2025-04-05_14:35:57.407150_tyOb 2025-04-05_14:35:57.407156_OWOq 2025-04-05_14:35:57.407162_YJOg
`c015807`	2025-04-08_14:50:58.331810_hRns 2025-04-08_14:50:58.331848_Qbsb 2025-04-08_14:50:58.331858_ridB 2025-04-08_14:50:58.331865_phRu 2025-04-08_14:50:58.331871_mKMv 2025-04-08_14:50:58.331879_lYcV 2025-04-08_14:50:58.331886_urvK 2025-04-08_14:50:58.331893_DAcN 2025-04-08_14:50:58.331899_PVsO 2025-04-08_14:50:58.331906_pKFk

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`9a07498`	`c015807`	Diff	Significant (?)
p10	200 ±3 ms	200 ±3 ms	+100 μs (+0.1%)	NO
p25	207 ±3 ms	207 ±4 ms	-168 μs (-0.1%)	NO
p50	214 ±4 ms	214 ±3 ms	+247 μs (+0.1%)	NO
p75	221 ±4 ms	223 ±4 ms	+1.85 ms (+0.8%)	NO
p90	229 ±5 ms	232 ±4 ms	+3.01 ms (+1.3%)	NO

20 test runs in comparison

Commit	Test Runs
`9a07498`	2025-04-05_14:35:57.407055_PjRP 2025-04-05_14:35:57.407091_hoTA 2025-04-05_14:35:57.407113_EkkX 2025-04-05_14:35:57.407123_ltEF 2025-04-05_14:35:57.407129_TgOG 2025-04-05_14:35:57.407136_dcuv 2025-04-05_14:35:57.407143_bDkx 2025-04-05_14:35:57.407150_tyOb 2025-04-05_14:35:57.407156_OWOq 2025-04-05_14:35:57.407162_YJOg
`c015807`	2025-04-08_14:50:58.331810_hRns 2025-04-08_14:50:58.331848_Qbsb 2025-04-08_14:50:58.331858_ridB 2025-04-08_14:50:58.331865_phRu 2025-04-08_14:50:58.331871_mKMv 2025-04-08_14:50:58.331879_lYcV 2025-04-08_14:50:58.331886_urvK 2025-04-08_14:50:58.331893_DAcN 2025-04-08_14:50:58.331899_PVsO 2025-04-08_14:50:58.331906_pKFk

redfin-30

Percentile	`9a07498`	`c015807`	Diff	Significant (?)
p10	225 ±4 ms	252 ±8 ms	+27.4 ms (+12.2%)	MAYBE
p25	230 ±3 ms	259 ±7 ms	+28.7 ms (+12.5%)	MAYBE
p50	238 ±3 ms	267 ±9.5 ms	+29.7 ms (+12.5%)	MAYBE
p75	246 ±3 ms	282 ±21 ms	+36.4 ms (+14.8%)	NO
p90	255 ±6 ms	309 ±51 ms	+53.7 ms (+21.0%)	NO

20 test runs in comparison

Commit	Test Runs
`9a07498`	2025-04-05_14:35:57.407055_PjRP 2025-04-05_14:35:57.407091_hoTA 2025-04-05_14:35:57.407113_EkkX 2025-04-05_14:35:57.407123_ltEF 2025-04-05_14:35:57.407129_TgOG 2025-04-05_14:35:57.407136_dcuv 2025-04-05_14:35:57.407143_bDkx 2025-04-05_14:35:57.407150_tyOb 2025-04-05_14:35:57.407156_OWOq 2025-04-05_14:35:57.407162_YJOg
`c015807`	2025-04-08_14:50:58.331810_hRns 2025-04-08_14:50:58.331848_Qbsb 2025-04-08_14:50:58.331858_ridB 2025-04-08_14:50:58.331865_phRu 2025-04-08_14:50:58.331871_mKMv 2025-04-08_14:50:58.331879_lYcV 2025-04-08_14:50:58.331886_urvK 2025-04-08_14:50:58.331893_DAcN 2025-04-08_14:50:58.331899_PVsO 2025-04-08_14:50:58.331906_pKFk

https://storage.googleapis.com/firebase-sdk-metric-reports/PiNAgNcM52/index.html

[encoders] Replace deprecated Kotlin Stdlib functions with recommende…

a31c019

…d ones

google-oss-bot added the size/XS label Apr 8, 2025

rlazo requested review from davidmotson and daymxn April 8, 2025 14:33

rlazo enabled auto-merge (squash) April 8, 2025 14:45

daymxn approved these changes Apr 8, 2025

View reviewed changes

rlazo merged commit f97833e into main Apr 8, 2025
38 of 40 checks passed

rlazo deleted the rl.fix.stdlib.encoders branch April 8, 2025 14:56

firebase locked and limited conversation to collaborators May 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[encoders] Replace deprecated Kotlin Stdlib functions with recommended ones #6845

[encoders] Replace deprecated Kotlin Stdlib functions with recommended ones #6845

Uh oh!

rlazo commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 8, 2025 •

edited

Loading

Uh oh!

google-oss-bot commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 8, 2025

Uh oh!

google-oss-bot commented Apr 8, 2025

Uh oh!

Uh oh!

google-oss-bot commented Apr 8, 2025

`fire-fcm`

`fire-transport`

`timeToInitialDisplay`

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[encoders] Replace deprecated Kotlin Stdlib functions with recommended ones #6845

[encoders] Replace deprecated Kotlin Stdlib functions with recommended ones #6845

Uh oh!

Conversation

rlazo commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Apr 8, 2025

Coverage Report 1

Affected Products

Test Logs

Uh oh!

github-actions bot commented Apr 8, 2025

Test Results

Uh oh!

google-oss-bot commented Apr 8, 2025

Size Report 1

Affected Products

Test Logs

Uh oh!

Uh oh!

google-oss-bot commented Apr 8, 2025

Startup Time Report 1

Notes

Startup Times

fire-fcm

fire-transport

timeToInitialDisplay

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 8, 2025 •

edited

Loading

Coverage Report ¹

Size Report ¹

Startup Time Report ¹

`fire-fcm`

`fire-transport`

`timeToInitialDisplay`