Skip to content

[Perf] Cache attribute key validation regex #6865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

[Perf] Cache attribute key validation regex #6865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6448a4a
[Perf] Cache attribute key validation regex
rlazo Apr 11, 2025
7fad6f7
Fix format
rlazo Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...se-perf/src/main/java/com/google/firebase/perf/metrics/validator/PerfMetricValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,16 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Locale;
import java.util.regex.Matcher;
import java.util.regex.Pattern;

/** An abstract class providing an interface to validate PerfMetric */
public abstract class PerfMetricValidator {

// Regex to validate Attribute key
private static final Pattern ATTRIBUTE_KEY_PATTERN =
Pattern.compile("^(?!(firebase_|google_|ga_))[A-Za-z][A-Za-z_0-9]*");

/**
* Creates a list of PerfMetricValidator classes based on the contents of PerfMetric
*
Expand Down Expand Up @@ -164,7 +170,8 @@ public static void validateAttribute(@NonNull String key, @NonNull String value)
Constants.MAX_ATTRIBUTE_VALUE_LENGTH));
}

if (!key.matches("^(?!(firebase_|google_|ga_))[A-Za-z][A-Za-z_0-9]*")) {
Matcher attributeKeyMatcher = ATTRIBUTE_KEY_PATTERN.matcher(key);
if (!attributeKeyMatcher.matches()) {
throw new IllegalArgumentException(
"Attribute key must start with letter, must only contain alphanumeric characters and"
+ " underscore and must not start with \"firebase_\", \"google_\" and \"ga_");
Expand Down
Loading