Skip to content

Update PerfSession and SessionManager to identify Legacy sessions. #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Changes for using AQS in Firebase Performance
merged 8 commits into from
Apr 14, 2025
Merged

Update PerfSession and SessionManager to identify Legacy sessions. #6867

merged 8 commits into from
Apr 14, 2025

Conversation

@tejasd
Copy link
Contributor

@tejasd tejasd commented Apr 11, 2025

This is a subset of changes in #6693.

@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@tejasd tejasd changed the base branch from main to fireperf-aqs April 11, 2025 16:11
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-perf

    Overall coverage changed from ? (7d9c0bf) to 70.49% (0b93744) by ?.

    107 individual files with coverage change

    FilenameBase (7d9c0bf)Merge (0b93744)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.55%?
    AppStateMonitor.java?84.97%?
    AppStateUpdateHandler.java?89.29%?
    Clock.java?100.00%?
    ConfigResolver.java?90.33%?
    ConfigurationConstants.java?97.93%?
    ConfigurationFlag.java?80.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?93.83%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.42%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?76.92%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?77.17%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?28.57%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?0.00%?
    FirebasePerformanceSessionSubscriber.kt?22.22%?
    FirebasePerformance_Factory.java?0.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.44%?
    FirebaseSessionsEnforcementCheck.kt?85.71%?
    FirebaseSessionsHelper.kt?100.00%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.37%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?100.00%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.45%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?89.66%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    Performance.kt?7.14%?
    PerfSession.java?93.55%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?90.28%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?95.83%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pTXeWqK3aB.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

Test Results

  110 files    110 suites   2m 12s ⏱️
  961 tests   961 ✅ 0 💤 0 ❌
1 930 runs  1 930 ✅ 0 💤 0 ❌

Results for commit 69bf460.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (7d9c0bf)Merge (0b93744)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-perf

    TypeBase (7d9c0bf)Merge (0b93744)Diff
    aar?320 kB? (?)
    apk (aggressive)?1.71 MB? (?)
    apk (release)?10.7 MB? (?)

  • firebase-sessions

    TypeBase (7d9c0bf)Merge (0b93744)Diff
    aar?202 kB? (?)
    apk (aggressive)?645 kB? (?)
    apk (release)?6.31 MB? (?)

  • protolite-well-known-types

    TypeBase (7d9c0bf)Merge (0b93744)Diff
    aar?1.02 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.71 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1QtyYAdWdO.html

@tejasd tejasd requested review from mrober and themiswang April 14, 2025 13:44
@tejasd tejasd merged commit 8fe1383 into fireperf-aqs Apr 14, 2025
30 of 32 checks passed
@tejasd tejasd deleted the td/perf-session branch April 14, 2025 15:06
mrober pushed a commit that referenced this pull request May 5, 2025
@tejasd @mrober
Update PerfSession and SessionManager to identify Legacy sessions. (#…
345394f 
…6867)

This is a subset of changes in
[#6693](#6693).
tejasd added a commit that referenced this pull request May 7, 2025
@tejasd
Update PerfSession and SessionManager to identify Legacy sessions. (#…
b9cff44 
…6867)

This is a subset of changes in
[#6693](#6693).
@firebase firebase locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrober mrober mrober approved these changes

@themiswang themiswang Awaiting requested review from themiswang

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tejasd @google-oss-bot @mrober