fix: Improve efficiency of online/offline composite index tests. #6868

ehsannas · 2025-04-11T18:47:21Z

#no-changelog

github-actions · 2025-04-11T18:47:32Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions · 2025-04-11T18:53:30Z

Test Results

186 files + 186 186 suites +186 5m 12s ⏱️ + 5m 12s
1 235 tests +1 235 1 219 ✅ +1 219 16 💤 +16 0 ❌ ±0
2 494 runs +2 494 2 462 ✅ +2 462 32 💤 +32 0 ❌ ±0

Results for commit 902f4cd. ± Comparison against base commit 5aff679.

♻️ This comment has been updated with latest results.

google-oss-bot · 2025-04-11T18:54:43Z

Coverage Report ¹

Affected Products

firebase-firestore
Overall coverage changed from 45.78% (5aff679) to 45.77% (5bdf299) by -0.01%.
Filename Base (5aff679) Merge (5bdf299) Diff
LruGarbageCollector.java 97.27% 93.64% -3.64%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/RFGiyGNdgf.html

google-oss-bot · 2025-04-11T19:02:42Z

Size Report ¹

Affected Products

No changes between base commit (5aff679) and merge commit (5bdf299).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/2B2lGc5BWH.html

google-oss-bot · 2025-04-11T19:23:28Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (5aff679) and the CI merge commit (5bdf299)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 5aff679: https://storage.googleapis.com/firebase-sdk-metric-reports/IXgaI6uBA1/index.html
- 5bdf299: https://storage.googleapis.com/firebase-sdk-metric-reports/FshCg9AiM1/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`5aff679`	`5bdf299`	Diff	Significant (?)
p10	268 ±11 μs	257 ±14 μs	-10.5 μs (-3.9%)	NO
p25	279 ±17 μs	266 ±17 μs	-12.7 μs (-4.6%)	NO
p50	299 ±27 μs	281 ±20 μs	-17.1 μs (-5.7%)	NO
p75	351 ±78 μs	337 ±72 μs	-13.9 μs (-4.0%)	NO
p90	420 ±117 μs	424 ±99 μs	+3.81 μs (+0.9%)	NO

20 test runs in comparison

Commit	Test Runs
`5aff679`	2025-04-15_16:09:20.117631_Awzg 2025-04-15_16:09:20.117668_NqMp 2025-04-15_16:09:20.117678_IupH 2025-04-15_16:09:20.117685_vhsp 2025-04-15_16:09:20.117692_vhaN 2025-04-15_16:09:20.117699_JHdq 2025-04-15_16:09:20.117724_pdQI 2025-04-15_16:09:20.117731_nlZP 2025-04-15_16:09:20.117738_Uqze 2025-04-15_16:09:20.117745_JMJd
`5bdf299`	2025-04-15_18:58:06.748879_vmYU 2025-04-15_18:58:06.748919_sdhT 2025-04-15_18:58:06.748928_Owqf 2025-04-15_18:58:06.748935_Rkck 2025-04-15_18:58:06.748941_WsXv 2025-04-15_18:58:06.748948_MHPX 2025-04-15_18:58:06.748954_pPyd 2025-04-15_18:58:06.748960_SgNk 2025-04-15_18:58:06.748984_zLla 2025-04-15_18:58:06.748991_fSGj

redfin-30

Percentile	`5aff679`	`5bdf299`	Diff	Significant (?)
p10	493 ±28 μs	499 ±18 μs	+5.80 μs (+1.2%)	NO
p25	513 ±29 μs	517 ±19 μs	+4.40 μs (+0.9%)	NO
p50	537 ±30 μs	542 ±25 μs	+5.02 μs (+0.9%)	NO
p75	571 ±32 μs	573 ±28 μs	+2.71 μs (+0.5%)	NO
p90	608 ±46 μs	615 ±41 μs	+7.77 μs (+1.3%)	NO

20 test runs in comparison

Commit	Test Runs
`5aff679`	2025-04-15_16:09:20.117631_Awzg 2025-04-15_16:09:20.117668_NqMp 2025-04-15_16:09:20.117678_IupH 2025-04-15_16:09:20.117685_vhsp 2025-04-15_16:09:20.117692_vhaN 2025-04-15_16:09:20.117699_JHdq 2025-04-15_16:09:20.117724_pdQI 2025-04-15_16:09:20.117731_nlZP 2025-04-15_16:09:20.117738_Uqze 2025-04-15_16:09:20.117745_JMJd
`5bdf299`	2025-04-15_18:58:06.748879_vmYU 2025-04-15_18:58:06.748919_sdhT 2025-04-15_18:58:06.748928_Owqf 2025-04-15_18:58:06.748935_Rkck 2025-04-15_18:58:06.748941_WsXv 2025-04-15_18:58:06.748948_MHPX 2025-04-15_18:58:06.748954_pPyd 2025-04-15_18:58:06.748960_SgNk 2025-04-15_18:58:06.748984_zLla 2025-04-15_18:58:06.748991_fSGj

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`5aff679`	`5bdf299`	Diff	Significant (?)
p10	196 ±5 ms	199 ±3 ms	+2.59 ms (+1.3%)	NO
p25	202 ±5 ms	204 ±3 ms	+1.90 ms (+0.9%)	NO
p50	209 ±5 ms	212 ±3 ms	+2.61 ms (+1.2%)	NO
p75	217 ±5 ms	221 ±5 ms	+4.40 ms (+2.0%)	NO
p90	224 ±5 ms	236 ±21 ms	+11.4 ms (+5.1%)	NO

20 test runs in comparison

Commit	Test Runs
`5aff679`	2025-04-15_16:09:20.117631_Awzg 2025-04-15_16:09:20.117668_NqMp 2025-04-15_16:09:20.117678_IupH 2025-04-15_16:09:20.117685_vhsp 2025-04-15_16:09:20.117692_vhaN 2025-04-15_16:09:20.117699_JHdq 2025-04-15_16:09:20.117724_pdQI 2025-04-15_16:09:20.117731_nlZP 2025-04-15_16:09:20.117738_Uqze 2025-04-15_16:09:20.117745_JMJd
`5bdf299`	2025-04-15_18:58:06.748879_vmYU 2025-04-15_18:58:06.748919_sdhT 2025-04-15_18:58:06.748928_Owqf 2025-04-15_18:58:06.748935_Rkck 2025-04-15_18:58:06.748941_WsXv 2025-04-15_18:58:06.748948_MHPX 2025-04-15_18:58:06.748954_pPyd 2025-04-15_18:58:06.748960_SgNk 2025-04-15_18:58:06.748984_zLla 2025-04-15_18:58:06.748991_fSGj

redfin-30

Percentile	`5aff679`	`5bdf299`	Diff	Significant (?)
p10	226 ±5 ms	251 ±5 ms	+24.9 ms (+11.0%)	MAYBE
p25	233 ±5 ms	257 ±4 ms	+23.9 ms (+10.2%)	MAYBE
p50	241 ±5 ms	266 ±4 ms	+25.0 ms (+10.4%)	MAYBE
p75	249 ±6 ms	275 ±5 ms	+25.9 ms (+10.4%)	MAYBE
p90	258 ±7 ms	290 ±8 ms	+31.3 ms (+12.1%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`5aff679`	2025-04-15_16:09:20.117631_Awzg 2025-04-15_16:09:20.117668_NqMp 2025-04-15_16:09:20.117678_IupH 2025-04-15_16:09:20.117685_vhsp 2025-04-15_16:09:20.117692_vhaN 2025-04-15_16:09:20.117699_JHdq 2025-04-15_16:09:20.117724_pdQI 2025-04-15_16:09:20.117731_nlZP 2025-04-15_16:09:20.117738_Uqze 2025-04-15_16:09:20.117745_JMJd
`5bdf299`	2025-04-15_18:58:06.748879_vmYU 2025-04-15_18:58:06.748919_sdhT 2025-04-15_18:58:06.748928_Owqf 2025-04-15_18:58:06.748935_Rkck 2025-04-15_18:58:06.748941_WsXv 2025-04-15_18:58:06.748948_MHPX 2025-04-15_18:58:06.748954_pPyd 2025-04-15_18:58:06.748960_SgNk 2025-04-15_18:58:06.748984_zLla 2025-04-15_18:58:06.748991_fSGj

https://storage.googleapis.com/firebase-sdk-metric-reports/eP8ltXab2s/index.html

milaGGL

LGTM

github-actions · 2025-04-15T18:40:10Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

fix: Improve efficiency of online/offline composite index tests.

7af87cd

ehsannas added the no-changelog label Apr 11, 2025

google-oss-bot added the size/XS label Apr 11, 2025

fix formatting.

862764f

ehsannas requested a review from milaGGL April 11, 2025 20:04

ehsannas assigned milaGGL Apr 11, 2025

milaGGL approved these changes Apr 14, 2025

View reviewed changes

Merge branch 'main' into ehsann/fix-tesutils

902f4cd

milaGGL merged commit 24fba9b into main Apr 15, 2025
30 of 32 checks passed

milaGGL deleted the ehsann/fix-tesutils branch April 15, 2025 19:11

firebase locked and limited conversation to collaborators May 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Improve efficiency of online/offline composite index tests. #6868

fix: Improve efficiency of online/offline composite index tests. #6868

Uh oh!

ehsannas commented Apr 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

google-oss-bot commented Apr 11, 2025 •

edited

Loading

`firebase-firestore`

Uh oh!

google-oss-bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

google-oss-bot commented Apr 11, 2025 •

edited

Loading

`fire-fst`

`timeToInitialDisplay`

Uh oh!

milaGGL left a comment

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: Improve efficiency of online/offline composite index tests. #6868

fix: Improve efficiency of online/offline composite index tests. #6868

Uh oh!

Conversation

ehsannas commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

github-actions bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

google-oss-bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

google-oss-bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

Test Logs

Uh oh!

google-oss-bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

Uh oh!

milaGGL left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 15, 2025

Vertex AI Mock Responses Check ⚠️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ehsannas commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading

google-oss-bot commented Apr 11, 2025 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

google-oss-bot commented Apr 11, 2025 •

edited

Loading

Size Report ¹

google-oss-bot commented Apr 11, 2025 •

edited

Loading

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`