Skip to content

Fallback mode v2 #6872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Merged sessions-sharedrepo into main
wants to merge 2 commits into from
Closed

Fallback mode v2 #6872

wants to merge 2 commits into from

Conversation

@themiswang
Copy link
Contributor

No description provided.

@themiswang themiswang requested a review from mrober April 14, 2025 14:59
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (9eb1210) to 77.83% (340e7ca) by ?.

    46 individual files with coverage change

    FilenameBase (9eb1210)Merge (340e7ca)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    DaggerFirebaseSessionsComponent.java?94.12%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?59.26%?
    FirebaseSessionsComponent.kt?65.79%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?100.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?100.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?90.91%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?10.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionData.kt?58.82%?
    SessionDataSerializer_Factory.java?0.00%?
    SessionDetails.kt?85.71%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?78.57%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?100.00%?
    SessionGenerator_Factory.java?0.00%?
    SessionInitiator.kt?12.50%?
    SessionsFallbackActivityLifecycleCallbacks.kt?53.13%?
    SessionsFallbackActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsSettings.kt?93.75%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    SharedSessionRepository.kt?35.29%?
    SharedSessionRepository_Factory.java?0.00%?
    TimeProvider.kt?62.50%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rR6PdYNAK6.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025 •
edited
Loading

Test Results

 32 files   32 suites   44s ⏱️
 68 tests  68 ✅ 0 💤 0 ❌
136 runs  136 ✅ 0 💤 0 ❌

Results for commit 3913038.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (9eb1210)Merge (340e7ca)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (9eb1210)Merge (340e7ca)Diff
    aar?204 kB? (?)
    apk (aggressive)?532 kB? (?)
    apk (release)?5.78 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sFMmiJ1uUd.html

@themiswang themiswang force-pushed the fallbackModeV2 branch 2 times, most recently from 51de344 to 0ccb865 Compare April 14, 2025 17:31
themiswang
themiswang commented Apr 14, 2025
View reviewed changes
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionInitiator.kt

override fun onActivityResumed(activity: Activity) = sharedSessionRepository.appForeground()
internal interface SessionLifecycleClient {
var localSessionData: SessionData
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var localSessionData: SessionData
private set()

themiswang
themiswang commented Apr 14, 2025
View reviewed changes
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionInitiator.kt
return lifecycleClient?.localSessionData?.sessionDetails
}
var lifecycleClient: SessionLifecycleClient? = null
set(lifecycleClient) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the setter

themiswang
themiswang commented Apr 14, 2025
View reviewed changes
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SharedSessionRepository.kt
private lateinit var localSessionData: SessionData
override lateinit var localSessionData: SessionData

private var jobForCancel: Job? = null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dataFlowJob

@themiswang themiswang closed this Apr 15, 2025
@firebase firebase locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrober mrober Awaiting requested review from mrober

Assignees

No one assigned

Labels

do-not-merge/work-in-progress size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@themiswang @google-oss-bot