Skip to content

dataconnect: testing: improvements to comment posted for nightly testing results #6879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

dataconnect: testing: improvements to comment posted for nightly testing results #6879

wants to merge 6 commits into from

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 15, 2025 •
edited
Loading

dataconnect.yml: improve send-notifications message and allow specifying issue via trksmnkncd_notification_issue=NNN in the PR body.

See #6863

trksmnkncd_notification_issue=6863

@dconeybe
dataconnect.yml: improve send-notifications message and allow specify…
a0a89a9 
…ing issue via trksmnkncd_notification_issue=6863 in the PR body
@dconeybe dconeybe self-assigned this Apr 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

Test Results

 1 019 files   -  15   1 019 suites   - 15   34m 38s ⏱️ +3s
 5 874 tests ±  0   5 851 ✅  -   1  22 💤 ±0  1 ❌ +1 
11 658 runs   - 153  11 613 ✅  - 154  44 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 4cef939. ± Comparison against base commit e98dd2c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (e98dd2c) and merge commit (94fb912).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3fXG22XGwg.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from ? (e98dd2c) to 84.30% (94fb912) by ?.

    34 individual files with coverage change

    FilenameBase (e98dd2c)Merge (94fb912)Diff
    AutoValue_ConfigUpdate.java?29.41%?
    Code.java?0.00%?
    ConfigAutoFetch.java?86.73%?
    ConfigCacheClient.java?93.33%?
    ConfigContainer.java?94.29%?
    ConfigFetchHandler.java?92.94%?
    ConfigFetchHttpClient.java?86.27%?
    ConfigGetParameterHandler.java?96.45%?
    ConfigRealtimeHandler.java?41.38%?
    ConfigRealtimeHttpClient.java?73.45%?
    ConfigSharedPrefsClient.java?87.50%?
    ConfigStorageClient.java?100.00%?
    ConfigUpdate.java?100.00%?
    ConfigUpdateListener.java?0.00%?
    ConfigUpdateListenerRegistration.java?0.00%?
    CustomSignals.java?100.00%?
    DefaultsXmlParser.java?0.00%?
    FirebaseRemoteConfig.java?89.76%?
    FirebaseRemoteConfigClientException.java?75.00%?
    FirebaseRemoteConfigException.java?95.65%?
    FirebaseRemoteConfigFetchThrottledException.java?100.00%?
    FirebaseRemoteConfigInfo.java?0.00%?
    FirebaseRemoteConfigInfoImpl.java?100.00%?
    FirebaseRemoteConfigServerException.java?68.42%?
    FirebaseRemoteConfigSettings.java?61.54%?
    FirebaseRemoteConfigValue.java?0.00%?
    FirebaseRemoteConfigValueImpl.java?84.62%?
    Personalization.java?91.43%?
    RemoteConfig.kt?31.58%?
    RemoteConfigComponent.java?90.70%?
    RemoteConfigConstants.java?0.00%?
    RemoteConfigRegistrar.java?100.00%?
    RolloutsStateFactory.java?95.24%?
    RolloutsStateSubscriptionsHandler.java?100.00%?

  • firebase-firestore

    Overall coverage changed from 45.78% (e98dd2c) to 45.78% (94fb912) by +0.00%.

    FilenameBase (e98dd2c)Merge (94fb912)Diff
    DeleteMutation.java90.48%95.24%+4.76%

  • firebase-messaging

    Overall coverage changed from 84.10% (e98dd2c) to 84.25% (94fb912) by +0.15%.

    FilenameBase (e98dd2c)Merge (94fb912)Diff
    FirebaseMessaging.java75.60%77.20%+1.60%

  • firebase-sessions

    Overall coverage changed from ? (e98dd2c) to 66.67% (94fb912) by ?.

    48 individual files with coverage change

    FilenameBase (e98dd2c)Merge (94fb912)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?100.00%?
    DaggerFirebaseSessionsComponent.java?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsComponent.kt?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDetailsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?0.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?0.00%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.73%?
    RemoteSettingsFetcher.kt?0.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?3.33%?
    SessionDataStoreConfigs.kt?100.00%?
    SessionDatastoreImpl_Factory.java?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?84.21%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?90.91%?
    SessionGenerator_Factory.java?0.00%?
    SessionLifecycleClient.kt?91.78%?
    SessionLifecycleService.kt?78.65%?
    SessionLifecycleServiceBinder.kt?0.00%?
    SessionLifecycleServiceBinderImpl_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?55.56%?
    SessionsSettings.kt?96.88%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?100.00%?
    SettingsCache.kt?93.55%?
    SettingsCache_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?
    UuidGenerator.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jRhYekzDgu.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025 •
edited
Loading

Startup Time Report 1

The report is too large (122,587 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/E1lqnb5Pcu/index.html

@dconeybe
Copy link
Contributor Author

closing in favor of #6880

@dconeybe dconeybe closed this Apr 17, 2025
@dconeybe dconeybe deleted the dconeybe/dataconnect/CiPostMessageImprovements branch April 17, 2025 04:42
@firebase firebase locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@dconeybe dconeybe

Labels
api: dataconnect do-not-merge/work-in-progress main-merge-ack no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @google-oss-bot