Skip to content

[ai] Address most tests failures #6915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

[ai] Address most tests failures #6915

merged 1 commit into from
Apr 28, 2025

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 28, 2025

Citation test still times out, but this address all other breakages.

@rlazo
[ai] Address most tests failures
d3c70e6 
Citation test still times out, but this address all other breakages.
@rlazo rlazo requested a review from davidmotson April 28, 2025 17:01
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 28, 2025

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@rlazo rlazo merged commit 268bcca into davidmotson.firebase-ai Apr 28, 2025
15 checks passed
@rlazo rlazo deleted the rlazo.fai.tests branch April 28, 2025 17:03
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 28, 2025

Coverage Report 1

Affected Products

No changes between base commit (197b090) and merge commit (c1ddd99).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EFfJzye5DM.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 28, 2025

Size Report 1

Affected Products

  • base

    TypeBase (197b090)Merge (c1ddd99)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-ai

    TypeBase (197b090)Merge (c1ddd99)Diff
    aar?801 kB? (?)
    apk (aggressive)?1.54 MB? (?)
    apk (release)?9.51 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NXNRTwP9IJ.html

@rlazo rlazo mentioned this pull request Apr 28, 2025
Merged
rlazo added a commit that referenced this pull request Apr 29, 2025
@rlazo @davidmotson @daymxn
[ai] Use .json for unary tests instead of .txt (#6916)
7924813 
Follow up to #6915

---------

Co-authored-by: David Motsonashvili <[email protected]>
Co-authored-by: David Motsonashvili <[email protected]>
Co-authored-by: Daymon <[email protected]>
@firebase firebase locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidmotson davidmotson davidmotson approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlazo @google-oss-bot @davidmotson