Add a NamedThreadFactory to WithinAppServiceConnection's Executor. #6980

gsakakihara · 2025-05-21T20:03:27Z

Added back the NamedThreadFactory used by scheduledExecutorService that was removed by 6383f6d

…ection Executor. - Add back the NamedThreadFactory used by scheduledExecutorService that was removed by 6383f6d

github-actions · 2025-05-21T20:03:43Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2025-05-21T20:12:39Z

Coverage Report ¹

Affected Products

firebase-messaging
Overall coverage changed from 84.13% (5db7bfb) to 84.02% (7a51aa4) by -0.11%.
Filename Base (5db7bfb) Merge (7a51aa4) Diff
Metadata.java 41.27% 36.51% -4.76%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/CFyAHeES2v.html

github-actions · 2025-05-21T20:14:06Z

Test Results

64 files + 46 64 suites +46 6m 12s ⏱️ + 5m 38s
487 tests +399 487 ✅ +399 0 💤 ±0 0 ❌ ±0
980 runs +804 980 ✅ +804 0 💤 ±0 0 ❌ ±0

Results for commit 32e1c12. ± Comparison against base commit 5db7bfb.

This pull request removes 88 and adds 487 tests. Note that renamed tests count towards both.

com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.SerializationTests ‑ test Candidate serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test GenerateContentResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test Schema serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test countTokensResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test modalityTokenCount serialization as Json
com.google.firebase.vertexai.VertexAIStreamingSnapshotTests ‑ citation parsed correctly
…

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[24]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[22]
…

google-oss-bot · 2025-05-21T20:17:53Z

Size Report ¹

Affected Products

firebase-messaging
Type Base (5db7bfb) Merge (7a51aa4) Diff
aar 149 kB 149 kB +56 B (+0.0%)
apk (aggressive) 578 kB 578 kB +60 B (+0.0%)
apk (release) 5.31 MB 5.31 MB +52 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/iQYpwjMFRx.html

google-oss-bot · 2025-05-21T20:35:14Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (5db7bfb) and the CI merge commit (7a51aa4)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 5db7bfb: https://storage.googleapis.com/firebase-sdk-metric-reports/1iLob37a97/index.html
- 7a51aa4: https://storage.googleapis.com/firebase-sdk-metric-reports/uTrDaPzz8R/index.html

Startup Times

`fire-fcm`

Device Statistics Distributions

oriole-32

Percentile	`5db7bfb`	`7a51aa4`	Diff	Significant (?)
p10	508 ±381 μs	1.04 ±1 ms	+532 μs (+104.9%)	NO
p25	550 ±407 μs	1.11 ±1 ms	+564 μs (+102.6%)	NO
p50	636 ±480 μs	1.26 ±1 ms	+622 μs (+97.8%)	NO
p75	810 ±561 μs	1.51 ±1 ms	+697 μs (+86.1%)	NO
p90	943 ±650 μs	1.78 ±1 ms	+842 μs (+89.3%)	NO

20 test runs in comparison

Commit	Test Runs
`5db7bfb`	2025-05-20_20:42:45.424781_vfIC 2025-05-20_20:42:45.424817_SrHK 2025-05-20_20:42:45.424845_iESY 2025-05-20_20:42:45.424871_SLqj 2025-05-20_20:42:45.424879_aWaF 2025-05-20_20:42:45.424886_KgJY 2025-05-20_20:42:45.424892_CyPK 2025-05-20_20:42:45.424899_FYnv 2025-05-20_20:42:45.424905_zRnh 2025-05-20_20:42:45.424911_yVCG
`7a51aa4`	2025-05-21_20:20:47.803233_FeJf 2025-05-21_20:20:47.803277_gOXO 2025-05-21_20:20:47.803286_DCMu 2025-05-21_20:20:47.803305_cEOS 2025-05-21_20:20:47.803312_sAtr 2025-05-21_20:20:47.803319_lAet 2025-05-21_20:20:47.803326_LiOB 2025-05-21_20:20:47.803334_UslZ 2025-05-21_20:20:47.803340_csHS 2025-05-21_20:20:47.803346_vrSW

redfin-30

Percentile	`5db7bfb`	`7a51aa4`	Diff	Significant (?)
p10	1.15 ±0.5 ms	1.39 ±1 ms	+241 μs (+21.0%)	NO
p25	1.37 ±0.7 ms	1.70 ±1 ms	+336 μs (+24.5%)	NO
p50	1.66 ±1 ms	2.10 ±2 ms	+439 μs (+26.4%)	NO
p75	2.12 ±1 ms	2.72 ±2 ms	+602 μs (+28.4%)	NO
p90	2.82 ±2 ms	3.63 ±3 ms	+814 μs (+28.9%)	NO

20 test runs in comparison

Commit	Test Runs
`5db7bfb`	2025-05-20_20:42:45.424781_vfIC 2025-05-20_20:42:45.424817_SrHK 2025-05-20_20:42:45.424845_iESY 2025-05-20_20:42:45.424871_SLqj 2025-05-20_20:42:45.424879_aWaF 2025-05-20_20:42:45.424886_KgJY 2025-05-20_20:42:45.424892_CyPK 2025-05-20_20:42:45.424899_FYnv 2025-05-20_20:42:45.424905_zRnh 2025-05-20_20:42:45.424911_yVCG
`7a51aa4`	2025-05-21_20:20:47.803233_FeJf 2025-05-21_20:20:47.803277_gOXO 2025-05-21_20:20:47.803286_DCMu 2025-05-21_20:20:47.803305_cEOS 2025-05-21_20:20:47.803312_sAtr 2025-05-21_20:20:47.803319_lAet 2025-05-21_20:20:47.803326_LiOB 2025-05-21_20:20:47.803334_UslZ 2025-05-21_20:20:47.803340_csHS 2025-05-21_20:20:47.803346_vrSW

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`5db7bfb`	`7a51aa4`	Diff	Significant (?)
p10	197 ±4 ms	200 ±4 ms	+2.96 ms (+1.5%)	NO
p25	203 ±4 ms	206 ±3 ms	+2.75 ms (+1.4%)	NO
p50	210 ±5 ms	212 ±3 ms	+2.75 ms (+1.3%)	NO
p75	217 ±5 ms	219 ±4 ms	+1.83 ms (+0.8%)	NO
p90	225 ±6 ms	231 ±6 ms	+6.14 ms (+2.7%)	NO

20 test runs in comparison

Commit	Test Runs
`5db7bfb`	2025-05-20_20:42:45.424781_vfIC 2025-05-20_20:42:45.424817_SrHK 2025-05-20_20:42:45.424845_iESY 2025-05-20_20:42:45.424871_SLqj 2025-05-20_20:42:45.424879_aWaF 2025-05-20_20:42:45.424886_KgJY 2025-05-20_20:42:45.424892_CyPK 2025-05-20_20:42:45.424899_FYnv 2025-05-20_20:42:45.424905_zRnh 2025-05-20_20:42:45.424911_yVCG
`7a51aa4`	2025-05-21_20:20:47.803233_FeJf 2025-05-21_20:20:47.803277_gOXO 2025-05-21_20:20:47.803286_DCMu 2025-05-21_20:20:47.803305_cEOS 2025-05-21_20:20:47.803312_sAtr 2025-05-21_20:20:47.803319_lAet 2025-05-21_20:20:47.803326_LiOB 2025-05-21_20:20:47.803334_UslZ 2025-05-21_20:20:47.803340_csHS 2025-05-21_20:20:47.803346_vrSW

redfin-30

Percentile	`5db7bfb`	`7a51aa4`	Diff	Significant (?)
p10	231 ±14 ms	247 ±3 ms	+16.4 ms (+7.1%)	NO
p25	238 ±15 ms	254 ±4 ms	+15.5 ms (+6.5%)	NO
p50	248 ±23 ms	261 ±4 ms	+13.3 ms (+5.3%)	NO
p75	259 ±28 ms	269 ±4 ms	+10.5 ms (+4.1%)	NO
p90	270 ±30 ms	285 ±8 ms	+15.0 ms (+5.6%)	NO

20 test runs in comparison

Commit	Test Runs
`5db7bfb`	2025-05-20_20:42:45.424781_vfIC 2025-05-20_20:42:45.424817_SrHK 2025-05-20_20:42:45.424845_iESY 2025-05-20_20:42:45.424871_SLqj 2025-05-20_20:42:45.424879_aWaF 2025-05-20_20:42:45.424886_KgJY 2025-05-20_20:42:45.424892_CyPK 2025-05-20_20:42:45.424899_FYnv 2025-05-20_20:42:45.424905_zRnh 2025-05-20_20:42:45.424911_yVCG
`7a51aa4`	2025-05-21_20:20:47.803233_FeJf 2025-05-21_20:20:47.803277_gOXO 2025-05-21_20:20:47.803286_DCMu 2025-05-21_20:20:47.803305_cEOS 2025-05-21_20:20:47.803312_sAtr 2025-05-21_20:20:47.803319_lAet 2025-05-21_20:20:47.803326_LiOB 2025-05-21_20:20:47.803334_UslZ 2025-05-21_20:20:47.803340_csHS 2025-05-21_20:20:47.803346_vrSW

https://storage.googleapis.com/firebase-sdk-metric-reports/qxp6zgiiuM/index.html

Add a NamedThreadFactory to WithinAppServiceConnection's service conn…

32e1c12

…ection Executor. - Add back the NamedThreadFactory used by scheduledExecutorService that was removed by 6383f6d

google-oss-bot added the size/XS label May 21, 2025

gsakakihara requested review from fredquintana, haibozha and welishr May 21, 2025 21:09

haibozha approved these changes May 28, 2025

View reviewed changes

gsakakihara merged commit 366095f into main May 28, 2025
38 checks passed

gsakakihara deleted the gsakakihara/named_thread branch May 28, 2025 17:48

firebase locked and limited conversation to collaborators Jun 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a NamedThreadFactory to WithinAppServiceConnection's Executor. #6980

Add a NamedThreadFactory to WithinAppServiceConnection's Executor. #6980

Uh oh!

gsakakihara commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

google-oss-bot commented May 21, 2025

`firebase-messaging`

Uh oh!

github-actions bot commented May 21, 2025

Uh oh!

google-oss-bot commented May 21, 2025

`firebase-messaging`

Uh oh!

google-oss-bot commented May 21, 2025

`fire-fcm`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add a NamedThreadFactory to WithinAppServiceConnection's Executor. #6980

Add a NamedThreadFactory to WithinAppServiceConnection's Executor. #6980

Uh oh!

Conversation

gsakakihara commented May 21, 2025

Uh oh!

github-actions bot commented May 21, 2025

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented May 21, 2025

Coverage Report 1

Affected Products

firebase-messaging

Test Logs

Uh oh!

github-actions bot commented May 21, 2025

Test Results

Uh oh!

google-oss-bot commented May 21, 2025

Size Report 1

Affected Products

firebase-messaging

Test Logs

Uh oh!

google-oss-bot commented May 21, 2025

Startup Time Report 1

Notes

Startup Times

fire-fcm

timeToInitialDisplay

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Coverage Report ¹

`firebase-messaging`

Size Report ¹

`firebase-messaging`

Startup Time Report ¹

`fire-fcm`

`timeToInitialDisplay`