Skip to content

Conversation

dconeybe
Copy link
Contributor

No description provided.

Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Test Results

   66 files  +  2     66 suites  +2   1m 18s ⏱️ - 1m 3s
  552 tests +233    551 ✅ +233  1 💤 ±0  0 ❌ ±0 
1 104 runs  +462  1 102 ✅ +462  2 💤 ±0  0 ❌ ±0 

Results for commit aea362f. ± Comparison against base commit ec4b353.

This pull request removes 319 and adds 552 tests. Note that renamed tests count towards both.
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addClickListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDismissListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDisplayErrorListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addImpressionListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addRemoveAllListeners_WorksAsExpected
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addRemoveListeners_WorksAsExpected
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_clearsInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_disablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionEnabling_enablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ clearDisplayListener_removesListener
…
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (normal cases)
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ streamListener_onNotifiedCard_showsCardMessage
com.google.firebase.dataconnect.ProtoStructDecoderUnitTest ‑ decodeFromStruct() can encode and decode a list of non-nullable Unit

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-dataconnect

    TypeBase (ec4b353)Merge (4e6540e)Diff
    aar703 kB703 kB+10 B (+0.0%)
    apk (release)10.0 MB10.0 MB+8 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wZDblDWocg.html

@dconeybe
Copy link
Contributor Author

This PR was temporary and never meant to be merged.

@dconeybe dconeybe closed this Jun 20, 2025
@dconeybe dconeybe deleted the dconeybe/dataconnect/TriggerCI branch June 20, 2025 17:15
@firebase firebase locked and limited conversation to collaborators Jul 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants