Skip to content

Do not notify subscribers when session didn't change #6988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Do not notify subscribers when session didn't change #6988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SharedSessionRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ constructor(
}

internal var previousNotificationType: NotificationType = NotificationType.GENERAL
private var previousSessionId: String = ""

init {
CoroutineScope(backgroundDispatcher).launch {
Expand Down Expand Up @@ -171,6 +172,10 @@ constructor(

private suspend fun notifySubscribers(sessionId: String, type: NotificationType) {
previousNotificationType = type
if (previousSessionId == sessionId) {
return
}
previousSessionId = sessionId
FirebaseSessionsDependencies.getRegisteredSubscribers().values.forEach { subscriber ->
// Notify subscribers, regardless of sampling and data collection state
subscriber.onSessionChanged(SessionSubscriber.SessionDetails(sessionId))
Expand Down
Loading