dataconnect: demo: build.gradle.kts: add ability to specify the Data Connect emulator executable to use #7032
Conversation
…Connect emulator executable to use.
This comment was marked as off-topic.
This comment was marked as off-topic.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dconeybe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Data Connect demo's Gradle build configuration by introducing a new option to explicitly define the path to the Data Connect emulator executable. This provides flexibility for developers who may need to use a specific version or a locally built emulator binary instead of relying on the one automatically managed by the Firebase CLI.
Highlights
- Emulator Executable Path: I've added the ability to specify the path to the Data Connect emulator executable via a new Gradle property (
dataConnect.demo.dataConnectEmulatorExecutable). This allows overriding the default emulator used by thefirebasecommand. - Environment Variable: When the custom emulator path is provided, the build script now sets the
DATACONNECT_EMULATOR_BINARY_PATHenvironment variable before executing thefirebasecommand, instructing it to use the specified binary. - Gradle Property Naming: I've updated the Gradle property names used in the demo build from
dataConnect.minimalApp.*todataConnect.demo.*for consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to specify a custom Data Connect emulator executable for the demo project. This is achieved by adding a new Gradle property, dataConnect.demo.dataConnectEmulatorExecutable, which, if set, will cause the DATACONNECT_EMULATOR_BINARY_PATH environment variable to be configured when running Firebase commands.
Test Results 1 073 files + 1 007 1 073 suites +1 007 35m 56s ⏱️ + 34m 39s For more details on these failures, see this check. Results for commit d505ece. ± Comparison against base commit f48eda6. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Data Connect demo’s Gradle build by adding the ability to override the emulator executable path.
- Introduces a new Gradle property for specifying a custom Data Connect emulator binary.
- Passes the custom binary path to the Firebase CLI through an environment variable.
- Updates property naming from minimalApp to demo for consistency.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| firebase-dataconnect/demo/gradle.properties | Adds documentation for new Gradle properties including the emulator path. |
| firebase-dataconnect/demo/build.gradle.kts | Introduces new inputs and passes the custom emulator executable to the Firebase CLI. |
| .github/workflows/dataconnect_demo_app.yml | Updates command-line Gradle property references from minimalApp to demo. |
Comments suppressed due to low confidence (1)
firebase-dataconnect/demo/build.gradle.kts:228
- Consider using dataConnectEmulatorExecutable.absolutePath when setting the environment variable to ensure a string path is passed to the Firebase CLI.
if (dataConnectEmulatorExecutable !== null) {
Size Report 1Affected ProductsNo changes between base commit (f48eda6) and merge commit (b0919f1).Test Logs |
…stead of just `dataConnectEmulatorExecutable`
Coverage Report 1Affected Products
Test Logs |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Enhance the Data Connect demo's Gradle build configuration by introducing a new option to explicitly define the path to the Data Connect emulator executable. This provides flexibility for developers who may need to use a specific version or a locally-built emulator binary instead of relying on the one automatically managed by the Firebase CLI.
Highlights
dataConnect.demo.dataConnectEmulatorExecutable). This allows overriding the default emulator used by thefirebasecommand.DATACONNECT_EMULATOR_BINARY_PATHenvironment variable before executing thefirebasecommand, instructing it to use the specified binary.dataConnect.minimalApp.*todataConnect.demo.*for consistency.