Skip to content

[Storage] Replace hardcoded SDK version with Config.OLDEST_SDK #7034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025
Merged

[Storage] Replace hardcoded SDK version with Config.OLDEST_SDK #7034

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a0586e
[Storage] Replace hardcoded SDK version with Config.OLDEST_SDK
rlazo Jun 13, 2025
87a55a3
Add robolectric properties file
rlazo Jun 14, 2025
3a8d4ac
robolectric file is not necessary
rlazo Jun 18, 2025
635d17d
Merge branch 'main' into rl.storage.config
rlazo Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions firebase-storage/src/test/java/com/google/firebase/storage/AdaptiveStreamBufferTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import static org.junit.Assert.assertArrayEquals;

import android.os.Build;
import com.google.firebase.storage.internal.AdaptiveStreamBuffer;
import java.io.ByteArrayInputStream;
import java.io.IOException;
Expand All @@ -30,7 +29,7 @@

/** Tests for {@link AdaptiveStreamBuffer}. */
@RunWith(RobolectricTestRunner.class)
@Config(sdk = Build.VERSION_CODES.LOLLIPOP_MR1)
@Config(sdk = Config.OLDEST_SDK)
public class AdaptiveStreamBufferTest {

@Rule public RetryRule retryRule = new RetryRule(3);
Expand Down
3 changes: 1 addition & 2 deletions firebase-storage/src/test/java/com/google/firebase/storage/DependencyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

package com.google.firebase.storage;

import android.os.Build;
import com.google.android.gms.tasks.Task;
import java.lang.reflect.Method;
import java.util.ArrayList;
Expand All @@ -29,7 +28,7 @@

/** Tests for {@link FirebaseStorage}. */
@RunWith(RobolectricTestRunner.class)
@Config(sdk = Build.VERSION_CODES.LOLLIPOP_MR1)
@Config(sdk = Config.OLDEST_SDK)
public class DependencyTest {

@Rule public RetryRule retryRule = new RetryRule(3);
Expand Down
3 changes: 1 addition & 2 deletions firebase-storage/src/test/java/com/google/firebase/storage/StorageReferenceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import static com.google.firebase.common.testutil.Assert.assertThrows;

import android.os.Build;
import androidx.test.core.app.ApplicationProvider;
import com.google.android.gms.tasks.Task;
import com.google.firebase.FirebaseApp;
Expand All @@ -38,7 +37,7 @@

/** Tests for {@link FirebaseStorage}. */
@RunWith(RobolectricTestRunner.class)
@Config(sdk = Build.VERSION_CODES.LOLLIPOP_MR1)
@Config(sdk = Config.OLDEST_SDK)
public class StorageReferenceTest {

@Rule public RetryRule retryRule = new RetryRule(3);
Expand Down
3 changes: 1 addition & 2 deletions firebase-storage/src/test/java/com/google/firebase/storage/StreamProgressWrapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import static com.google.firebase.common.testutil.Assert.assertThrows;

import android.os.Build;
import com.google.firebase.storage.StreamDownloadTask.StreamProgressWrapper;
import com.google.firebase.storage.network.MockInputStreamHelper;
import java.io.ByteArrayInputStream;
Expand All @@ -35,7 +34,7 @@

/** Tests for {@link StreamProgressWrapper}. */
@RunWith(RobolectricTestRunner.class)
@Config(sdk = Build.VERSION_CODES.LOLLIPOP_MR1)
@Config(sdk = Config.OLDEST_SDK)
@SuppressWarnings("ResultOfMethodCallIgnored")
public class StreamProgressWrapperTest {

Expand Down
Loading