Skip to content

Upgrade ktor to 3.1.3 to avoid conflict version when use in KMP project #7062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Upgrade ktor to 3.1.3 to avoid conflict version when use in KMP project #7062

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911d1a3
Bump ktor to latest to avoid conflict version for current project usi…
hieuwu Jun 21, 2025
80d02de
Upgrade kotlin
hieuwu Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ javalite = "3.25.5"
jsonassert = "1.5.0"
kotest = "5.9.0" # Do not use 5.9.1 because it reverts the fix for https://github.com/kotest/kotest/issues/3981
kotestAssertionsCore = "5.8.1"
kotlin = "1.8.22"
ktorVersion = "2.3.2"
kotlin = "2.1.0"
ktorVersion = "3.1.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading Ktor from version 2.x to 3.x is a major version change that can introduce breaking API changes. For example, the HttpTimeout plugin, which seems related to the issue you're fixing, has been significantly reworked in Ktor 3.

Could you please confirm that you've:

  • Analyzed the Ktor 3.0 migration guide for any necessary code changes in modules that use Ktor (like firebase-ai)?
  • Run all relevant tests to ensure that this version bump doesn't introduce any regressions?

This is important to ensure the stability of the SDK.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated in 80d02de .

legacySupportV4 = "1.0.0"
lifecycleProcess = "2.3.1"
material = "1.12.0"
Expand Down