[Ai] Update api.txt #7071
[Ai] Update api.txt #7071
Conversation
This is a follow up to #7042
Firebase AI Mock Responses Check
|
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rlazo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on API evolution by deprecating a specific field within the CountTokensResponse structure in the Firebase AI API. This change signals to consumers that the totalBillableCharacters field is no longer the recommended way to retrieve billing-related token counts, likely guiding them towards alternative or more precise mechanisms for token accounting, as suggested by the PR's follow-up nature to #7042.
Highlights
- API Deprecation: The
totalBillableCharactersfield, its corresponding getter method (getTotalBillableCharacters), and the constructor parameter within theCountTokensResponseclass have all been marked as@Deprecatedinfirebase-ai/api.txt.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Generated by 🚫 Danger |
There was a problem hiding this comment.
Code Review
This pull request updates the api.txt file to reflect the deprecation of the totalBillableCharacters field in the CountTokensResponse class. The changes correctly apply the @Deprecated annotation to the constructor parameter, getter method, and property, aligning the API definition with the Kotlin source code. This is a positive step for API evolution and clarity. One area for potential future improvement, if api.txt is a primary API reference, is to explore ways to include deprecation messages within this format to provide more context to API consumers.
Coverage Report 1Affected ProductsNo changes between base commit (89c2f6c) and merge commit (de804a8).Test Logs |
Test Results 24 files - 945 24 suites - 945 34s ⏱️ - 27m 49s Results for commit cea3259. ± Comparison against base commit 89c2f6c. This pull request removes 5443 tests. |
Size Report 1Affected ProductsNo changes between base commit (89c2f6c) and merge commit (de804a8).Test Logs |
3 participants
This is a follow up to #7042