Skip to content

[Config] Annotate Builder with @CanIgnoreReturnValue #7100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

[Config] Annotate Builder with @CanIgnoreReturnValue #7100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase-config/firebase-config.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ dependencies {
annotationProcessor(libs.autovalue)
javadocClasspath(libs.autovalue.annotations)
compileOnly(libs.autovalue.annotations)
compileOnly(libs.errorprone.annotations)
compileOnly(libs.findbugs.jsr305)

// Testing
Expand Down
8 changes: 8 additions & 0 deletions firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

package com.google.firebase.remoteconfig.internal;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import java.util.Date;
import java.util.HashMap;
import java.util.HashSet;
Expand Down Expand Up @@ -328,11 +329,13 @@ public Builder(ConfigContainer otherContainer) {
this.builderRolloutMetadata = otherContainer.getRolloutMetadata();
}

@CanIgnoreReturnValue
public Builder replaceConfigsWith(Map<String, String> configsMap) {
this.builderConfigsJson = new JSONObject(configsMap);
return this;
}

@CanIgnoreReturnValue
public Builder replaceConfigsWith(JSONObject configsJson) {
try {
this.builderConfigsJson = new JSONObject(configsJson.toString());
Expand All @@ -345,11 +348,13 @@ public Builder replaceConfigsWith(JSONObject configsJson) {
return this;
}

@CanIgnoreReturnValue
public Builder withFetchTime(Date fetchTime) {
this.builderFetchTime = fetchTime;
return this;
}

@CanIgnoreReturnValue
public Builder withAbtExperiments(JSONArray abtExperiments) {
try {
this.builderAbtExperiments = new JSONArray(abtExperiments.toString());
Expand All @@ -362,6 +367,7 @@ public Builder withAbtExperiments(JSONArray abtExperiments) {
return this;
}

@CanIgnoreReturnValue
public Builder withPersonalizationMetadata(JSONObject personalizationMetadata) {
try {
this.builderPersonalizationMetadata = new JSONObject(personalizationMetadata.toString());
Expand All @@ -374,11 +380,13 @@ public Builder withPersonalizationMetadata(JSONObject personalizationMetadata) {
return this;
}

@CanIgnoreReturnValue
public Builder withTemplateVersionNumber(long templateVersionNumber) {
this.builderTemplateVersionNumber = templateVersionNumber;
return this;
}

@CanIgnoreReturnValue
public Builder withRolloutMetadata(JSONArray rolloutMetadata) {
try {
this.builderRolloutMetadata = new JSONArray(rolloutMetadata.toString());
Expand Down
Loading