Skip to content

[Config] Add unused vars for some call sites #7101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
+22 −18
Merged

[Config] Add unused vars for some call sites #7101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24fe110
[Config] Add unused vars for some call sites
rlazo Jul 3, 2025
096086f
Fix format
rlazo Jul 3, 2025
52cf656
Merge branch 'main' into rl.config.extrafix
rlazo Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigAutoFetch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import java.util.Random;
import java.util.Set;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
import org.json.JSONException;
import org.json.JSONObject;
Expand Down Expand Up @@ -248,15 +249,16 @@ private void autoFetch(int remainingAttempts, long targetVersion) {

// Randomize fetch to occur between 0 - 4 seconds.
int timeTillFetch = random.nextInt(4);
scheduledExecutorService.schedule(
new Runnable() {
@Override
public void run() {
fetchLatestConfig(remainingAttempts, targetVersion);
}
},
timeTillFetch,
TimeUnit.SECONDS);
ScheduledFuture<?> unused =
scheduledExecutorService.schedule(
new Runnable() {
@Override
public void run() {
Task<Void> unused = fetchLatestConfig(remainingAttempts, targetVersion);
}
},
timeTillFetch,
TimeUnit.SECONDS);
}

@VisibleForTesting
Expand Down
20 changes: 11 additions & 9 deletions ...fig/src/main/java/com/google/firebase/remoteconfig/internal/ConfigRealtimeHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
import java.util.Random;
import java.util.Set;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
Expand Down Expand Up @@ -381,15 +382,16 @@ private synchronized void makeRealtimeHttpConnection(long retryMilliseconds) {

if (httpRetriesRemaining > 0) {
httpRetriesRemaining--;
scheduledExecutorService.schedule(
new Runnable() {
@Override
public void run() {
beginRealtimeHttpStream();
}
},
retryMilliseconds,
TimeUnit.MILLISECONDS);
ScheduledFuture<?> unused =
scheduledExecutorService.schedule(
new Runnable() {
@Override
public void run() {
beginRealtimeHttpStream();
}
},
retryMilliseconds,
TimeUnit.MILLISECONDS);
} else if (!isInBackground) {
propagateErrors(
new FirebaseRemoteConfigClientException(
Expand Down