Skip to content

Remove VisibleForTesting from SDK production code #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
+1 −4
Merged

Remove VisibleForTesting from SDK production code #7103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
097baee
Remove VisibleForTesting from SDK production code
tusharkhandelwal8 Jul 4, 2025
c2206ea
Merge branch 'main' into update-code-annotation
tusharkhandelwal8 Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...se-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public class ConfigFetchHandler {
*
* <p>Defined here since {@link HttpURLConnection} does not provide this code.
*/
@VisibleForTesting static final int HTTP_TOO_MANY_REQUESTS = 429;
static final int HTTP_TOO_MANY_REQUESTS = 429;

/**
* First-open time key name in GA user-properties. First-open time is a predefined user-dimension
Expand Down
3 changes: 0 additions & 3 deletions ...nfig/src/main/java/com/google/firebase/remoteconfig/internal/ConfigSharedPrefsClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ Date getBackoffEndTime() {
// Realtime exponential backoff logic.
// -----------------------------------------------------------------

@VisibleForTesting
public RealtimeBackoffMetadata getRealtimeBackoffMetadata() {
synchronized (realtimeBackoffMetadataLock) {
return new RealtimeBackoffMetadata(
Expand All @@ -394,7 +393,6 @@ void setRealtimeBackoffMetadata(int numFailedStreams, Date backoffEndTime) {
}
}

@VisibleForTesting
public void setRealtimeBackoffEndTime(Date backoffEndTime) {
synchronized (realtimeBackoffMetadataLock) {
frcSharedPrefs
Expand All @@ -415,7 +413,6 @@ void resetRealtimeBackoff() {
* <p>The purpose of this class is to avoid race conditions when retrieving backoff metadata
* values separately.
*/
@VisibleForTesting
public static class RealtimeBackoffMetadata {
private int numFailedStreams;
private Date backoffEndTime;
Expand Down
Loading