-
Notifications
You must be signed in to change notification settings - Fork 643
dataconnect: DataConnectExecutableVersions.json updated with version 2.10.0 #7163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…2.10.0 This was done by running the following command: ``` ./gradlew :firebase-dataconnect:connectors:updateJson -Pversions=2.10.0 -PdefaultVersion=2.10.0 ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dconeybe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the DataConnect executable versions configuration to set 2.10.0
as the new default. It also includes the necessary metadata for this new version across different operating systems, which notably introduces official support for user-defined enums.
Highlights
- Default Version Update: The
defaultVersion
for DataConnect executables has been updated from2.9.1
to2.10.0
. - New Executable Version Added: Metadata for DataConnect executable version
2.10.0
has been added, including file sizes and SHA512 digests for Windows, macOS, and Linux platforms. - Feature Support: The newly added
2.10.0
version of the DataConnect executable notably introduces official support for user-defined enums.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates DataConnectExecutableVersions.json
to add version 2.10.0
and set it as the default. The change itself is straightforward and appears to be script-generated. My review includes a suggestion to consider refactoring the JSON structure to improve long-term maintainability and performance as the file continues to grow.
...n/resources/com/google/firebase/dataconnect/gradle/plugin/DataConnectExecutableVersions.json
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Size Report 1Affected ProductsNo changes between base commit (a7d26f5) and merge commit (96dbc08).Test Logs |
DataConnectExecutableVersions.json updated with version 2.10.0 by running:
Notably, this updated version adds official support for user-defined enums.