Skip to content

apk-size: report clear error message when "sdk" string cannot be parsed #7206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 11, 2025
Merged

apk-size: report clear error message when "sdk" string cannot be parsed #7206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b218b3
health-metrics/apk-size/app/configure.gradle: report clear error mess…
dconeybe Jul 31, 2025
b974acd
binary_size.py: avoid running the binary size calculation if no sdks …
dconeybe Jul 31, 2025
9f64f17
Merge branch 'main' into dconeybe/ApkSizeSdkParseErrorMessage
dconeybe Aug 1, 2025
8cbc943
Merge branch 'main' into dconeybe/ApkSizeSdkParseErrorMessage
dconeybe Aug 1, 2025
549decf
Merge branch 'main' into dconeybe/ApkSizeSdkParseErrorMessage
dconeybe Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ci/fireci/fireciplugins/binary_size.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ def binary_size(pull_request, log, metrics_service_url, access_token):
affected_artifacts, all_artifacts = _parse_artifacts()
artifacts = affected_artifacts if pull_request else all_artifacts
sdks = ','.join(artifacts)
if not sdks:
_logger.info(
"No sdks found whose binary size to measure ("
"pull_request=%s affected_artifacts=%s all_artifacts=%s)",
pull_request, affected_artifacts, all_artifacts
)
return

workdir = 'health-metrics/apk-size'
process = gradle.run('assemble', '--continue', gradle.P('sdks', sdks), workdir=workdir, check=False)
Expand Down
9 changes: 8 additions & 1 deletion health-metrics/apk-size/app/configure.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,14 @@ repositories {
if (project.hasProperty('sdks')) {
project.android {
sdks.split(',').each { sdk ->
def (groupId, artifactId, version) = sdk.split(':')
def sdkParts = sdk.split(':')
if (sdkParts.size() != 3) {
throw new GradleException(
"Invalid SDK format: '${sdk}'. " +
"Expected format: 'groupId:artifactId:version' (sdks: '${sdks}')"
)
}
def (groupId, artifactId, version) = sdkParts
productFlavors.create(artifactId) {
dimension 'firebase'
}
Expand Down
Loading