Skip to content

Update legacy session logs to include trace names. #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

Update legacy session logs to include trace names. #7258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions firebase-perf/src/main/java/com/google/firebase/perf/transport/TransportManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ public void log(final TraceMetric traceMetric) {
* {@link #isAllowedToDispatch(PerfMetric)}).
*/
public void log(final TraceMetric traceMetric, final ApplicationProcessState appState) {
checkSessionsList(traceMetric.getPerfSessionsList(), "log(TraceMetric)");
checkSessionsList(traceMetric.getPerfSessionsList(), traceMetric.getName());
executorService.execute(
() -> syncLog(PerfMetric.newBuilder().setTraceMetric(traceMetric), appState));
}
Expand Down Expand Up @@ -330,7 +330,7 @@ public void log(final NetworkRequestMetric networkRequestMetric) {
*/
public void log(
final NetworkRequestMetric networkRequestMetric, final ApplicationProcessState appState) {
checkSessionsList(networkRequestMetric.getPerfSessionsList(), "log(NetworkRequestMetric)");
checkSessionsList(networkRequestMetric.getPerfSessionsList(), networkRequestMetric.getUrl());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL from networkRequestMetric.getUrl() can be very long, which might result in excessively long log messages. This could be problematic for logging systems and hard to read. It's a good practice to truncate long strings before logging them.

    String url = networkRequestMetric.getUrl();
    checkSessionsList(
        networkRequestMetric.getPerfSessionsList(),
        url.length() > 128 ? url.substring(0, 128) + "..." : url);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

executorService.execute(
() ->
syncLog(
Expand Down
Loading