Skip to content

feat: Skip tests for doc-only changes #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2025
Merged

feat: Skip tests for doc-only changes #7306

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66ea30e
feat: Skip tests for doc-only changes
google-labs-jules[bot] Aug 27, 2025
ffd16b4
Merge branch 'main' into skip-doc-tests
rlazo Aug 27, 2025
f5c8437
Use comparison from guava
rlazo Aug 27, 2025
20c32ae
Merge branch 'main' into skip-doc-tests
rlazo Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions plugins/src/main/java/com/google/firebase/gradle/plugins/ci/AffectedProjectFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ public AffectedProjectFinder(Project project, List<Pattern> ignorePaths) {
this(project, changedPaths(project.getRootDir()), ignorePaths);
}

private static final Set<String> DOC_EXTENSIONS = ImmutableSet.of("md", "txt", "html");

public AffectedProjectFinder(
Project project, Set<String> changedPaths, List<Pattern> ignorePaths) {
this.project = project;
Expand All @@ -53,9 +55,17 @@ public AffectedProjectFinder(
}
return true;
})
.filter(p -> !isDocFile(p))
.collect(Collectors.toSet());
}

private static boolean isDocFile(String path) {
if (path.startsWith("docs/")) {
return true;
}
return DOC_EXTENSIONS.stream().anyMatch(ext -> path.endsWith("." + ext));
}

Set<Project> find() {
Set<String> paths = new HashSet<>(changedPaths);
Set<Project> projects = changedSubProjects(project, paths);
Expand Down
Loading