Skip to content

Add code samples to comments #7347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: wuandy/PortMoreExpr
Choose a base branch
from
Open

Add code samples to comments #7347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,577 changes: 806 additions & 771 deletions firebase-firestore/api.txt
View file
Open in desktop

Large diffs are not rendered by default.

774 changes: 575 additions & 199 deletions firebase-firestore/src/androidTest/java/com/google/firebase/firestore/PipelineTest.java
View file
Open in desktop

Large diffs are not rendered by default.

44 changes: 22 additions & 22 deletions ...ase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryToPipelineTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void testLimitQueries() {

Query query = collection.limit(2);
FirebaseFirestore db = collection.firestore;
PipelineSnapshot set = waitFor(db.pipeline().createFrom(query).execute());
Pipeline.Snapshot set = waitFor(db.pipeline().createFrom(query).execute());
List<Map<String, Object>> data = pipelineSnapshotToValues(set);
assertEquals(asList(map("k", "a"), map("k", "b")), data);
}
Expand All @@ -84,7 +84,7 @@ public void testLimitQueriesUsingDescendingSortOrder() {

Query query = collection.limit(2).orderBy("sort", Direction.DESCENDING);
FirebaseFirestore db = collection.firestore;
PipelineSnapshot set = waitFor(db.pipeline().createFrom(query).execute());
Pipeline.Snapshot set = waitFor(db.pipeline().createFrom(query).execute());

List<Map<String, Object>> data = pipelineSnapshotToValues(set);
assertEquals(asList(map("k", "d", "sort", 2L), map("k", "c", "sort", 1L)), data);
Expand Down Expand Up @@ -114,7 +114,7 @@ public void testLimitToLastQueriesWithCursors() {
Query query = collection.limitToLast(3).orderBy("sort").endBefore(2);
FirebaseFirestore db = collection.firestore;

PipelineSnapshot set = waitFor(db.pipeline().createFrom(query).execute());
Pipeline.Snapshot set = waitFor(db.pipeline().createFrom(query).execute());
List<Map<String, Object>> data = pipelineSnapshotToValues(set);
assertEquals(
asList(map("k", "a", "sort", 0L), map("k", "b", "sort", 1L), map("k", "c", "sort", 1L)),
Expand Down Expand Up @@ -162,7 +162,7 @@ public void testKeyOrderIsDescendingForDescendingInequality() {

Query query = collection.whereGreaterThan("foo", 21.0).orderBy("foo", Direction.DESCENDING);
FirebaseFirestore db = collection.firestore;
PipelineSnapshot result = waitFor(db.pipeline().createFrom(query).execute());
Pipeline.Snapshot result = waitFor(db.pipeline().createFrom(query).execute());
assertEquals(asList("g", "f", "c", "b", "a"), pipelineSnapshotToIds(result));
}

Expand All @@ -175,7 +175,7 @@ public void testUnaryFilterQueries() {
"b", map("null", null, "nan", 0),
"c", map("null", false, "nan", Double.NaN)));
FirebaseFirestore db = collection.firestore;
PipelineSnapshot results =
Pipeline.Snapshot results =
waitFor(
db.pipeline()
.createFrom(collection.whereEqualTo("null", null).whereEqualTo("nan", Double.NaN))
Expand All @@ -195,7 +195,7 @@ public void testFilterOnInfinity() {
"a", map("inf", Double.POSITIVE_INFINITY),
"b", map("inf", Double.NEGATIVE_INFINITY)));
FirebaseFirestore db = collection.firestore;
PipelineSnapshot results =
Pipeline.Snapshot results =
waitFor(
db.pipeline()
.createFrom(collection.whereEqualTo("inf", Double.POSITIVE_INFINITY))
Expand All @@ -215,7 +215,7 @@ public void testCanExplicitlySortByDocumentId() {
FirebaseFirestore db = collection.firestore;
// Ideally this would be descending to validate it's different than
// the default, but that requires an extra index
PipelineSnapshot docs =
Pipeline.Snapshot docs =
waitFor(db.pipeline().createFrom(collection.orderBy(FieldPath.documentId())).execute());
assertEquals(
asList(testDocs.get("a"), testDocs.get("b"), testDocs.get("c")),
Expand All @@ -232,7 +232,7 @@ public void testCanQueryByDocumentId() {
"bb", map("key", "bb"));
CollectionReference collection = testCollectionWithDocs(testDocs);
FirebaseFirestore db = collection.firestore;
PipelineSnapshot docs =
Pipeline.Snapshot docs =
waitFor(
db.pipeline()
.createFrom(collection.whereEqualTo(FieldPath.documentId(), "ab"))
Expand Down Expand Up @@ -260,7 +260,7 @@ public void testCanQueryByDocumentIdUsingRefs() {
"bb", map("key", "bb"));
CollectionReference collection = testCollectionWithDocs(testDocs);
FirebaseFirestore db = collection.firestore;
PipelineSnapshot docs =
Pipeline.Snapshot docs =
waitFor(
db.pipeline()
.createFrom(
Expand All @@ -284,11 +284,11 @@ public void testCanQueryWithAndWithoutDocumentKey() {
CollectionReference collection = testCollection();
FirebaseFirestore db = collection.firestore;
collection.add(map());
Task<PipelineSnapshot> query1 =
Task<Pipeline.Snapshot> query1 =
db.pipeline()
.createFrom(collection.orderBy(FieldPath.documentId(), Direction.ASCENDING))
.execute();
Task<PipelineSnapshot> query2 = db.pipeline().createFrom(collection).execute();
Task<Pipeline.Snapshot> query2 = db.pipeline().createFrom(collection).execute();

waitFor(query1);
waitFor(query2);
Expand Down Expand Up @@ -325,7 +325,7 @@ public void testQueriesCanUseNotEqualFilters() {
expectedDocsMap.remove("i");
expectedDocsMap.remove("j");

PipelineSnapshot snapshot =
Pipeline.Snapshot snapshot =
waitFor(db.pipeline().createFrom(collection.whereNotEqualTo("zip", 98101L)).execute());
assertEquals(Lists.newArrayList(expectedDocsMap.values()), pipelineSnapshotToValues(snapshot));

Expand Down Expand Up @@ -372,7 +372,7 @@ public void testQueriesCanUseNotEqualFiltersWithDocIds() {
"bb", docD);
CollectionReference collection = testCollectionWithDocs(testDocs);
FirebaseFirestore db = collection.firestore;
PipelineSnapshot docs =
Pipeline.Snapshot docs =
waitFor(
db.pipeline()
.createFrom(collection.whereNotEqualTo(FieldPath.documentId(), "aa"))
Expand All @@ -394,7 +394,7 @@ public void testQueriesCanUseArrayContainsFilters() {
FirebaseFirestore db = collection.firestore;

// Search for "array" to contain 42
PipelineSnapshot snapshot =
Pipeline.Snapshot snapshot =
waitFor(db.pipeline().createFrom(collection.whereArrayContains("array", 42L)).execute());
assertEquals(asList(docA, docB, docD), pipelineSnapshotToValues(snapshot));

Expand Down Expand Up @@ -426,7 +426,7 @@ public void testQueriesCanUseInFilters() {
FirebaseFirestore db = collection.firestore;

// Search for zips matching 98101, 98103, or [98101, 98102].
PipelineSnapshot snapshot =
Pipeline.Snapshot snapshot =
waitFor(
db.pipeline()
.createFrom(
Expand Down Expand Up @@ -480,7 +480,7 @@ public void testQueriesCanUseInFiltersWithDocIds() {
"bb", docD);
CollectionReference collection = testCollectionWithDocs(testDocs);
FirebaseFirestore db = collection.firestore;
PipelineSnapshot docs =
Pipeline.Snapshot docs =
waitFor(
db.pipeline()
.createFrom(collection.whereIn(FieldPath.documentId(), asList("aa", "ab")))
Expand Down Expand Up @@ -518,7 +518,7 @@ public void testQueriesCanUseNotInFilters() {
expectedDocsMap.remove("i");
expectedDocsMap.remove("j");

PipelineSnapshot snapshot =
Pipeline.Snapshot snapshot =
waitFor(
db.pipeline()
.createFrom(
Expand Down Expand Up @@ -581,7 +581,7 @@ public void testQueriesCanUseNotInFiltersWithDocIds() {
"bb", docD);
CollectionReference collection = testCollectionWithDocs(testDocs);
FirebaseFirestore db = collection.firestore;
PipelineSnapshot docs =
Pipeline.Snapshot docs =
waitFor(
db.pipeline()
.createFrom(collection.whereNotIn(FieldPath.documentId(), asList("aa", "ab")))
Expand Down Expand Up @@ -611,7 +611,7 @@ public void testQueriesCanUseArrayContainsAnyFilters() {
// Search for "array" to contain [42, 43].
Pipeline pipeline =
db.pipeline().createFrom(collection.whereArrayContainsAny("array", asList(42L, 43L)));
PipelineSnapshot snapshot = waitFor(pipeline.execute());
Pipeline.Snapshot snapshot = waitFor(pipeline.execute());
assertEquals(asList(docA, docB, docD, docE), pipelineSnapshotToValues(snapshot));

// With objects.
Expand Down Expand Up @@ -673,7 +673,7 @@ public void testCollectionGroupQueries() {
}
waitFor(batch.commit());

PipelineSnapshot snapshot =
Pipeline.Snapshot snapshot =
waitFor(db.pipeline().createFrom(db.collectionGroup(collectionGroup)).execute());
assertEquals(
asList("cg-doc1", "cg-doc2", "cg-doc3", "cg-doc4", "cg-doc5"),
Expand Down Expand Up @@ -703,7 +703,7 @@ public void testCollectionGroupQueriesWithStartAtEndAtWithArbitraryDocumentIds()
}
waitFor(batch.commit());

PipelineSnapshot snapshot =
Pipeline.Snapshot snapshot =
waitFor(
db.pipeline()
.createFrom(
Expand Down Expand Up @@ -749,7 +749,7 @@ public void testCollectionGroupQueriesWithWhereFiltersOnArbitraryDocumentIds() {
}
waitFor(batch.commit());

PipelineSnapshot snapshot =
Pipeline.Snapshot snapshot =
waitFor(
db.pipeline()
.createFrom(
Expand Down
Loading
Loading