Skip to content

dataconnect: replace post_comment_for_job_results.py with the :firebase-dataconnect:postCommentForJobResults gradle task #7358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dataconnect: replace post_comment_for_job_results.py with the :firebase-dataconnect:postCommentForJobResults gradle task #7358

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4bc34a
dataconnect: replace `post_comment_for_job_results.py` with the `:fir…
dconeybe Sep 10, 2025
8c1a630
code cleanup, GithubClient.kt created
dconeybe Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
229 changes: 0 additions & 229 deletions firebase-dataconnect/ci/post_comment_for_job_results.py
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions firebase-dataconnect/firebase-dataconnect.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import com.google.firebase.dataconnect.gradle.plugin.DataConnectExecutableVersionsRegistry
import com.google.firebase.dataconnect.gradle.plugin.UpdateDataConnectExecutableVersionsTask
import com.google.firebase.dataconnect.gradle.ci.PostCommentForJobResultsTask
import org.gradle.kotlin.dsl.withType
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
import org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile
Expand Down Expand Up @@ -176,3 +177,7 @@ tasks.register<UpdateDataConnectExecutableVersionsTask>("updateJson") {
)
workDirectory.set(project.layout.buildDirectory.dir("updateJson"))
}

tasks.register<PostCommentForJobResultsTask>("postCommentForJobResults") {
workDirectory.set(project.layout.buildDirectory.dir("postCommentForJobResults"))
}
Loading
Loading