Modify Analytics on desktop to use a verified DLL on Windows (although it is currently still a stub). #4882
lint.yml
on: pull_request
lint_warnings_check_and_comment
27s
Annotations
1 warning
|
lint_warnings_check_and_comment
Found 6 lint warnings:
analytics/src/analytics_windows.cc:84: An else should appear on the same line as the preceding } [whitespace/newline] [4]
analytics/src/analytics_windows.cc:84: If an else has a brace on one side, it should have it on both [readability/braces] [5]
analytics/src/analytics_windows.cc:298: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
analytics/src/analytics_windows.cc:300: Namespace should be terminated with "// namespace internal" [readability/namespace] [5]
analytics/src/analytics_windows.cc:301: Namespace should be terminated with "// namespace analytics" [readability/namespace] [5]
analytics/src/analytics_windows.cc:30: Failed to find complete declaration of namespace firebase [build/namespaces] [5]
|