Updated Analytics Windows to allow multiple DLL hashes, and add usage of Options struct. #4952
lint.yml
on: pull_request
lint_warnings_check_and_comment
56s
Annotations
1 warning
lint_warnings_check_and_comment
Found 13 lint warnings:
analytics/src/analytics_desktop_dynamic.h:17: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_SRC_ANALYTICS_DESKTOP_DYNAMIC_H_ [build/header_guard] [5]
analytics/src/analytics_desktop_dynamic.h:220: #endif line should be "#endif // FIREBASE_ANALYTICS_SRC_ANALYTICS_DESKTOP_DYNAMIC_H_" [build/header_guard] [5]
analytics/src/analytics_desktop_dynamic.h:23: "stdbool.h" already included at analytics/src/analytics_desktop_dynamic.h:20 [build/include] [4]
analytics/src/analytics_windows.cc:102: At least two spaces is best between code and comments [whitespace/comments] [2]
analytics/src/analytics_windows.cc:290: An else should appear on the same line as the preceding } [whitespace/newline] [4]
analytics/src/analytics_windows.cc:290: If an else has a brace on one side, it should have it on both [readability/braces] [5]
analytics/src/analytics_windows.cc:291: Tab found; better to use spaces [whitespace/tab] [1]
analytics/windows/include/public/analytics.h:1: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_ANALYTICS_H_ [build/header_guard] [5]
analytics/windows/include/public/c/analytics.h:1: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_C_ANALYTICS_H_ [build/header_guard] [5]
analytics/windows/include/public/event_names.h:1: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_EVENT_NAMES_H_ [build/header_guard] [5]
analytics/windows/include/public/event_names.h:425: #endif line should be "#endif // FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_EVENT_NAMES_H_" [build/header_guard] [5]
analytics/windows/include/public/parameter_names.h:1: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_PARAMETER_NAMES_H_ [build/header_guard] [5]
analytics/windows/include/public/parameter_names.h:252: #endif line should be "#endif // FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_PARAMETER_NAMES_H_" [build/header_guard] [5]
|