Updated Analytics Windows to allow multiple DLL hashes, and add usage of Options struct. #4963
jonsimantovlint.yml
on: pull_request
lint_warnings_check_and_comment
27s
Annotations
1 warning
|
lint_warnings_check_and_comment
Found 8 lint warnings:
analytics/src/analytics_desktop_dynamic.h:17: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_SRC_ANALYTICS_DESKTOP_DYNAMIC_H_ [build/header_guard] [5]
analytics/src/analytics_desktop_dynamic.h:25: "stdbool.h" already included at analytics/src/analytics_desktop_dynamic.h:22 [build/include] [4]
analytics/windows/include/public/analytics.h:3: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_ANALYTICS_H_ [build/header_guard] [5]
analytics/windows/include/public/c/analytics.h:3: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_C_ANALYTICS_H_ [build/header_guard] [5]
analytics/windows/include/public/event_names.h:3: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_EVENT_NAMES_H_ [build/header_guard] [5]
analytics/windows/include/public/event_names.h:427: #endif line should be "#endif // FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_EVENT_NAMES_H_" [build/header_guard] [5]
analytics/windows/include/public/parameter_names.h:3: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_PARAMETER_NAMES_H_ [build/header_guard] [5]
analytics/windows/include/public/parameter_names.h:254: #endif line should be "#endif // FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_PARAMETER_NAMES_H_" [build/header_guard] [5]
|