Analytics windows dll update #5117
lint.yml
on: pull_request
lint_warnings_check_and_comment
24s
Annotations
1 warning
|
lint_warnings_check_and_comment
Found 6 lint warnings:
analytics/src/analytics_desktop.cc:54: Static/global string variables are not permitted. [runtime/string] [4]
analytics/src/analytics_desktop_dynamic.c:366: At least two spaces is best between code and comments [whitespace/comments] [2]
analytics/windows/include/public/analytics.h:15: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_ANALYTICS_H_ [build/header_guard] [5]
analytics/windows/include/public/c/analytics.h:15: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_C_ANALYTICS_H_ [build/header_guard] [5]
analytics/windows/include/public/event_names.h:15: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_EVENT_NAMES_H_ [build/header_guard] [5]
analytics/windows/include/public/parameter_names.h:15: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_PARAMETER_NAMES_H_ [build/header_guard] [5]
|