Skip to content

Remove unnecessary swig logic from Analytics #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Remove unnecessary swig logic from Analytics #1641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26ed5fb
Remove unnecessary swig logic from Analytics
a-maurice Sep 10, 2024
2e1b151
Merge branch 'main' into am-analytics_rewrite
a-maurice Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions analytics/src/include/firebase/analytics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,14 +453,6 @@ void LogEvent(const char* name, const char* parameter_name,
/// @endif
void LogEvent(const char* name);

// clang-format off
#ifdef SWIG
// Modify the following overload with unsafe, so that we can do some pinning
// in the C# code.
%csmethodmodifiers LogEvent "public unsafe"
#endif // SWIG
// clang-format on

/// @brief Log an event with associated parameters.
///
/// An Event is an important occurrence in your app that you want to
Expand Down
Loading