Skip to content

Change all ubuntu-20 runners to ubuntu-22 #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 11, 2025
Merged

Change all ubuntu-20 runners to ubuntu-22 #1693

merged 20 commits into from
Mar 11, 2025

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Feb 14, 2025 •
edited
Loading

Description

Switch all ubuntu-20 runners to ubuntu-22, as ubuntu-20 is deprecated and will be going away at the end of the month.

Testing

Integration test in this PR.
Packaging workflow (includes 32-bit Linux build): https://github.com/firebase/firebase-cpp-sdk/actions/runs/13687100597

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Feb 14, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Feb 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit f350d0e
Last updated: Tue Mar 11 16:02 PDT 2025
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  WriteBatchTest.TestBatchesFailAtomicallyRaisingCorrectEvents

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov changed the title Change all ubuntu-20 runners to ubuntu-22. Let's see what happens. Change all ubuntu-20 runners to ubuntu-22 Feb 14, 2025
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Feb 14, 2025
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Feb 14, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 14, 2025
@morganchen12 morganchen12 mentioned this pull request Feb 19, 2025
Closed
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 5, 2025
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 6, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Mar 6, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 6, 2025
@jonsimantov jonsimantov requested a review from a-maurice March 6, 2025 17:55
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Mar 6, 2025
@jonsimantov jonsimantov merged commit f350d0e into main Mar 11, 2025
60 of 84 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Mar 11, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 11, 2025
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Mar 11, 2025
@firebase firebase locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsimantov @a-maurice