-
Notifications
You must be signed in to change notification settings - Fork 125
feat: Implement UseUserAccessGroup for iOS #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -373,5 +373,13 @@ AUTH_RESULT_FN(Auth, SignInWithEmailAndPassword, AuthResult) | |
|
||
AUTH_RESULT_FN(Auth, CreateUserWithEmailAndPassword, AuthResult) | ||
|
||
#if !FIREBASE_PLATFORM_IOS | ||
// Stub for non-iOS platforms. | ||
void Auth::UseUserAccessGroup(const char* user_access_group) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function isn't necessary in this file, since it's covered in all 3 platform-specific files. |
||
// This function is only implemented on iOS. | ||
(void)user_access_group; // Mark as used to avoid compiler warnings. | ||
} | ||
#endif // !FIREBASE_PLATFORM_IOS | ||
|
||
} // namespace auth | ||
} // namespace firebase |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -768,5 +768,13 @@ void IdTokenRefreshThread::DisableAuthRefresh() { | |
ref_count_--; | ||
} | ||
|
||
#if !FIREBASE_PLATFORM_IOS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need for the #if here. |
||
// Stub for non-iOS platforms. | ||
void Auth::UseUserAccessGroup(const char* user_access_group) { | ||
// This function is only implemented on iOS. | ||
(void)user_access_group; // Mark as used to avoid compiler warnings. | ||
} | ||
#endif // !FIREBASE_PLATFORM_IOS | ||
|
||
} // namespace auth | ||
} // namespace firebase |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -608,5 +608,22 @@ void DisableTokenAutoRefresh(AuthData *auth_data) {} | |
void InitializeTokenRefresher(AuthData *auth_data) {} | ||
void DestroyTokenRefresher(AuthData *auth_data) {} | ||
|
||
void Auth::UseUserAccessGroup(const char* user_access_group) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please change the method to return AuthError so we can properly handle if any error is returned. |
||
if (!auth_data_) return; | ||
NSString* access_group_nsstring = nil; | ||
if (user_access_group != nullptr && strlen(user_access_group) > 0) { | ||
access_group_nsstring = [NSString stringWithUTF8String:user_access_group]; | ||
} | ||
|
||
NSError* error = nil; | ||
BOOL success = [AuthImpl(auth_data_) useUserAccessGroup:access_group_nsstring error:&error]; | ||
if (!success || error) { | ||
LogWarning("Error setting user access group: %s", | ||
[[error localizedDescription] UTF8String]); | ||
// Note: The C++ method is void, so we're not propagating the error further up. | ||
// If specific error handling is needed in C++, the method signature would need to change. | ||
} | ||
} | ||
|
||
} // namespace auth | ||
} // namespace firebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the #if.