-
Notifications
You must be signed in to change notification settings - Fork 125
Implement UseUserAccessGroup for Firebase Auth C++ SDK #1754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -608,5 +608,23 @@ void DisableTokenAutoRefresh(AuthData *auth_data) {} | |
void InitializeTokenRefresher(AuthData *auth_data) {} | ||
void DestroyTokenRefresher(AuthData *auth_data) {} | ||
|
||
AuthError Auth::UseUserAccessGroup(const char* access_group_str) { | ||
if (!auth_data_) { | ||
return kAuthErrorUninitialized; | ||
} | ||
NSString* access_group_ns_str = nil; | ||
if (access_group_str != nullptr && strlen(access_group_str) > 0) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there is a blank string, let's pass it in verbatim instead of nil. Remember to update the docs to reflect this. |
||
access_group_ns_str = [NSString stringWithUTF8String:access_group_str]; | ||
} | ||
|
||
NSError* error = nil; | ||
BOOL success = [AuthImpl(auth_data_) useUserAccessGroup:access_group_ns_str error:&error]; | ||
if (success) { | ||
return kAuthErrorNone; | ||
} else { | ||
return AuthErrorFromNSError(error); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you double-check which error codes this might return and make sure there are values for all of them in the AuthError enum and the AuthErrorFromNSError function? |
||
} | ||
} | ||
|
||
} // namespace auth | ||
} // namespace firebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android also needs this stub.