Skip to content

Remove deprecated Auth function from C++ SDK #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
13 changes: 4 additions & 9 deletions auth/integration_test/src/integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -761,18 +761,13 @@ TEST_F(FirebaseAuthTest, TestUpdateEmailAndPassword) {
firebase::auth::User user = auth_->current_user();
EXPECT_TRUE(user.is_valid());

// Update the user's email and password.
// const std::string new_email = "new_" + email;
// WaitForCompletion(user.UpdateEmail(new_email.c_str()), "UpdateEmail");
// Update the user's password.
// Email update functionality has been changed and the old UpdateEmail method removed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove this second part completely.

// A more comprehensive test for the new email update flow
// (SendEmailVerificationBeforeUpdatingEmail) would be needed here.
WaitForCompletion(user.UpdatePassword(kTestPasswordUpdated),
"UpdatePassword");

// firebase::auth::Credential new_email_cred =
// firebase::auth::EmailAuthProvider::GetCredential(new_email.c_str(),
// kTestPasswordUpdated);
// WaitForCompletion(user.Reauthenticate(new_email_cred), "Reauthenticate");
// EXPECT_TRUE(user.is_valid());

WaitForCompletion(user.SendEmailVerification(), "SendEmailVerification");
DeleteUser();
}
Expand Down
Loading