Update the tvOS simulator version used by tests #1786
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an incompatibility issue with GitHub Actions runners by updating the tvOS simulator version used for tests. The change ensures that the continuous integration pipeline can continue to execute tests successfully, as the previously used tvOS 16.1 simulator is no longer available by default on the GHA runners. The update involves modifying a configuration script to reflect the new, supported simulator version.
Highlights
- tvOS Simulator Version Update: The
tvos_simulatorversion in thescripts/gha/print_matrix_configuration.pyfile has been updated from 16.1 to 17.2. This change is crucial because GitHub Actions runners no longer have tvOS 16.1 available by default, ensuring that tests continue to run successfully with an officially supported simulator version.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the tvOS simulator version to 17.2, which is necessary due to changes in the GitHub Actions runner environments. The change is approved. I've added one comment regarding the use of a hardcoded version string, suggesting a small refactoring to improve future maintainability by using a constant.
github-actions
bot
added
the
tests: in-progress
✅ Integration test succeeded!Requested by @a-maurice on commit e6e11bd |
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Description
The GHA runners no longer have tvOS 16.1 available by default, so change to 17.2 instead.
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md#installed-simulators
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.