Skip to content

Guard remote config response parsing from empty FlatBuffer #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Guard remote config response parsing from empty FlatBuffer #1790

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d73b86
Guard remote config response parsing from empty FlatBuffer
triplef Sep 26, 2025
c33ae4d
Improve guard check
triplef Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions remote_config/src/desktop/remote_config_response.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ void RemoteConfigResponse::MarkCompleted() {
return;
}
const flatbuffers::FlatBufferBuilder& builder = parser_->builder_;
if (builder.GetSize() == 0 || builder.GetBufferPointer() == nullptr) {
return;
}
const fbs::Response* body_fbs =
flatbuffers::GetRoot<fbs::Response>(builder.GetBufferPointer());

Expand Down