Skip to content

Allow emitting eventarc channels as params #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow emitting eventarc channels as params #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export interface ManifestEndpoint {
eventTrigger?: {
eventFilters: Record<string, string | Expression<string>>;
eventFilterPathPatterns?: Record<string, string | Expression<string>>;
channel?: string;
channel?: string | Expression<string>;
eventType: string;
retry: boolean | Expression<boolean> | ResetValue;
region?: string;
Expand Down
2 changes: 1 addition & 1 deletion src/v2/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ export interface EventHandlerOptions extends Omit<GlobalOptions, "enforceAppChec
serviceAccount?: string | ResetValue;

/** The name of the channel where the function receives events. */
channel?: string;
channel?: string | Expression<string>;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/eventarc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export interface EventarcTriggerOptions extends options.EventHandlerOptions {
* If not specified, the default Firebase channel will be used:
* `projects/{project}/locations/us-central1/channels/firebase`
*/
channel?: string;
channel?: string | Expression<string>;

/**
* Eventarc event exact match filter.
Expand Down