Fix retry in event triggers

CHANGELOG.md

@@ -1,3 +1,4 @@
 - Remove HTTP server shutdown message. (#1457)
 - Add features to task queue functions. (#1423)
 - Add traces to V2 Firestore trigger logs. (#1440)
+- Fix retry in event triggered functions. (#1463)

src/v2/providers/alerts/alerts.ts

@@ -249,7 +249,7 @@ export function getEndpointAnnotation(
       eventFilters: {
         alerttype: alertType,
       },
-      retry: !!opts.retry,
+      retry: opts.retry || false,
     },
   };
   if (appId) {

src/v2/providers/database.ts

@@ -446,7 +446,7 @@ export function makeEndpoint(
       eventType,
       eventFilters,
       eventFilterPathPatterns,
-      retry: false,
+      retry: opts.retry || false,
     },
   };
 }

src/v2/providers/eventarc.ts

@@ -216,7 +216,7 @@ export function onCustomEventPublished<T = any>(
     eventTrigger: {
       eventType: opts.eventType,
       eventFilters: {},
-      retry: false,
+      retry: opts.retry || false,
       channel,
     },
   };

src/v2/providers/firestore.ts

@@ -426,7 +426,7 @@ export function makeEndpoint(
       eventType,
       eventFilters,
       eventFilterPathPatterns,
-      retry: !!opts.retry,
+      retry: opts.retry || false,
     },
   };
 }

src/v2/providers/pubsub.ts

@@ -344,7 +344,7 @@ export function onMessagePublished<T = any>(
     eventTrigger: {
       eventType: "google.cloud.pubsub.topic.v1.messagePublished",
       eventFilters: { topic },
-      retry: false,
+      retry: opts.retry || false,
     },
   };
   copyIfPresent(endpoint.eventTrigger, opts, "retry", "retry");

src/v2/providers/remoteConfig.ts

@@ -145,7 +145,7 @@ export function onConfigUpdated(
     eventTrigger: {
       eventType,
       eventFilters: {},
-      retry: !!optsOrHandler.retry,
+      retry: optsOrHandler.retry || false,
     },
   };
   func.__endpoint = ep;

src/v2/providers/storage.ts

@@ -603,7 +603,7 @@ export function onOperation(
         eventTrigger: {
           eventType,
           eventFilters: { bucket },
-          retry: false,
+          retry: opts.retry || false,
         },
       };
       copyIfPresent(endpoint.eventTrigger, opts, "retry", "retry");

src/v2/providers/tasks.ts

@@ -281,6 +281,7 @@ export function onTaskDispatched<Args = any>(
     convertInvoker
   );
   convertIfPresent(func.__endpoint.taskQueueTrigger, opts, "invoker", "invoker", convertInvoker);
+  copyIfPresent(func.__endpoint.taskQueueTrigger, opts, "retry", "retry");
 
   func.__requiredAPIs = [
     {

src/v2/providers/testLab.ts

@@ -206,7 +206,7 @@ export function onTestMatrixCompleted(
     eventTrigger: {
       eventType,
       eventFilters: {},
-      retry: !!optsOrHandler.retry,
+      retry: optsOrHandler.retry || false,
     },
   };
   func.__endpoint = ep;