Skip to content

Fix bug with CORS options for an array of one item for onCall (#1563) #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Fix bug with CORS options for an array of one item for onCall (#1563) #1564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
826d507
Fix bug with CORS options for an array of one item for `onCall` (#1563)
bjester May 5, 2024
b78b740
Merge branch 'master' into cors-fix2
taeold Aug 22, 2024
0406537
Merge branch 'master' into cors-fix2
taeold Aug 26, 2024
d7af9c9
Merge branch 'master' into cors-fix2
taeold Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fix retry in event triggered functions. (#1463)
- Expose retry configuration in v2 RTDB trigger (#1588)
- Fix CORS options for v2 callable functions (#1564)
- Remove invalid `enforceAppCheck` option for v2 onRequest trigger (#1477)
2 changes: 1 addition & 1 deletion src/v2/providers/https.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export function onCall<T = any, Return = any | Promise<any>>(
// on the origin header of the request. If there is only one element in the
// array, this is unnecessary.
if (Array.isArray(origin) && origin.length === 1) {
origin = origin[1];
origin = origin[0];
}

// onCallHandler sniffs the function length to determine which API to present.
Expand Down
Loading