Skip to content

Fix bug where wrapInit wasn't called on v2 callable functions. #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 7, 2024
+2 −1
Merged

Fix bug where wrapInit wasn't called on v2 callable functions. #1634

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
223a4fa
Fix bug where wrapInit wasn't called on v2 callable functions.
taeold Nov 7, 2024
a7d009a
Merge branch 'master' of https://github.com/firebase/firebase-functio…
taeold Nov 7, 2024
994b07d
Add changelog.
taeold Nov 7, 2024
a4d384c
Fix formatting issue.
taeold Nov 7, 2024
6b36f0a
Merge branch 'master' into dl-forgot-init
taeold Nov 7, 2024
fc9713a
Fix formatting.
taeold Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Add support for callable function to return streaming response (#1629)
- Fix bug where wrapInit wasn't called on v2 callable functions. (#1634)
- Add support for callable function to return streaming response (#1629)
2 changes: 1 addition & 1 deletion src/v2/providers/https.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ export function onCall<T = any, Return = any | Promise<any>>(
"gcfv2"
);

func = wrapTraceContext(func);
func = wrapTraceContext(withInit(func));

Object.defineProperty(func, "__trigger", {
get: () => {
Expand Down
Loading